You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/02/14 23:41:59 UTC
[GitHub] [kafka] mjsax opened a new pull request #11759: MINOR: improve JavaDocs for ReadOnlySessionStore
mjsax opened a new pull request #11759:
URL: https://github.com/apache/kafka/pull/11759
The JavaDocs explaining the `findSession` search interval is correct, but hard to understand. We should be more explicit how it works.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] guozhangwang commented on a change in pull request #11759: MINOR: improve JavaDocs for ReadOnlySessionStore
Posted by GitBox <gi...@apache.org>.
guozhangwang commented on a change in pull request #11759:
URL: https://github.com/apache/kafka/pull/11759#discussion_r806350276
##########
File path: streams/src/main/java/org/apache/kafka/streams/state/ReadOnlySessionStore.java
##########
@@ -226,14 +323,14 @@
* Get the value of key from a single session.
*
* @param key the key to fetch
- * @param earliestSessionEndTime start timestamp of the session
- * @param latestSessionStartTime end timestamp of the session
+ * @param sessionStartTime start timestamp of the session
+ * @param sessionEndTime end timestamp of the session
Review comment:
I think we need to update the `@return` javadoc as `null if either no session with the exact start and end timestamp exist, or the specified key cannot be found in that session`, same below.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] guozhangwang commented on a change in pull request #11759: MINOR: improve JavaDocs for ReadOnlySessionStore
Posted by GitBox <gi...@apache.org>.
guozhangwang commented on a change in pull request #11759:
URL: https://github.com/apache/kafka/pull/11759#discussion_r806350276
##########
File path: streams/src/main/java/org/apache/kafka/streams/state/ReadOnlySessionStore.java
##########
@@ -226,14 +323,14 @@
* Get the value of key from a single session.
*
* @param key the key to fetch
- * @param earliestSessionEndTime start timestamp of the session
- * @param latestSessionStartTime end timestamp of the session
+ * @param sessionStartTime start timestamp of the session
+ * @param sessionEndTime end timestamp of the session
Review comment:
I think we need to update the `@return` javadoc as `null if either no session with the exact start and end timestamp exist, or the specified key cannot be found in that session`, same below.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mjsax merged pull request #11759: MINOR: improve JavaDocs for ReadOnlySessionStore
Posted by GitBox <gi...@apache.org>.
mjsax merged pull request #11759:
URL: https://github.com/apache/kafka/pull/11759
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org