[GitHub] [rocketmq] mxsm commented on a diff in pull request #6750: [ISSUE #6748]Optimize NettyRemotingAbstract#writeResponse log print

["mxsm (via GitHub)" <gi...@apache.org>]

mxsm commented on code in PR #6750:
URL: https://github.com/apache/rocketmq/pull/6750#discussion_r1193954848


##########
remoting/src/main/java/org/apache/rocketmq/remoting/netty/NettyRemotingAbstract.java:
##########
@@ -216,10 +216,7 @@ public static void writeResponse(Channel channel, RemotingCommand request, @Null
         response.markResponseType();
         try {
             channel.writeAndFlush(response).addListener((ChannelFutureListener) future -> {
-                if (future.isSuccess()) {
-                    log.debug("Response[request code: {}, response code: {}, opaque: {}] is written to channel{}",
-                        request.getCode(), response.getCode(), response.getOpaque(), channel);

Review Comment:
   > The log level is debug, but it also affects performance, right?
   
   This is the place I noticed when generating memory allocation flame graphs with async-profiler while performing stress testing with JMeter. However, I don’t seem to have found any log printing for debug configuration.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org