[GitHub] [spark] cloud-fan commented on a change in pull request #28316: [SPARK-31532][SQL] Builder should not propagate static sql configs to the existing active or default SparkSession

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #28316:
URL: https://github.com/apache/spark/pull/28316#discussion_r414241927



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala
##########
@@ -905,7 +905,9 @@ object SparkSession extends Logging {
       // Get the session from current thread's active session.
       var session = activeThreadSession.get()
       if ((session ne null) && !session.sparkContext.isStopped) {
-        options.foreach { case (k, v) => session.sessionState.conf.setConfString(k, v) }
+        for ((k, v) <- options if !SQLConf.staticConfKeys.contains(k)) {

Review comment:
       +1




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org