You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@streampark.apache.org by GitBox <gi...@apache.org> on 2022/12/07 15:26:09 UTC
[GitHub] [incubator-streampark] wolfboys opened a new pull request, #2139: [Bug] project git clone by ssh bug fixed
wolfboys opened a new pull request, #2139:
URL: https://github.com/apache/incubator-streampark/pull/2139
[Bug] project git clone by ssh bug fixed
## What changes were proposed in this pull request
Issue Number: close #2135
<!--(For example: This pull request proposed to add checkstyle plugin).-->
## Brief change log
<!--*(for example:)*
- *Add maven-checkstyle-plugin to root pom.xml*
-->
## Verifying this change
<!--*(Please pick either of the following options)*-->
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
<!--*(example:)*
- *Added integration tests for end-to-end.*
- *Added *Test to verify the change.*
- *Manually verified the change by testing locally.* -->
## Does this pull request potentially affect one of the following parts
- Dependencies (does it add or upgrade a dependency): yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampark] MonsterChenzhuo merged pull request #2139: [Bug] project git clone by ssh bug fixed
Posted by GitBox <gi...@apache.org>.
MonsterChenzhuo merged PR #2139:
URL: https://github.com/apache/incubator-streampark/pull/2139
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampark] MonsterChenzhuo commented on pull request #2139: [Bug] project git clone by ssh bug fixed
Posted by GitBox <gi...@apache.org>.
MonsterChenzhuo commented on PR #2139:
URL: https://github.com/apache/incubator-streampark/pull/2139#issuecomment-1342414939
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampark] github-actions[bot] commented on a diff in pull request #2139: [Bug] project git clone by ssh bug fixed
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on code in PR #2139:
URL: https://github.com/apache/incubator-streampark/pull/2139#discussion_r1042350624
##########
streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/base/util/GitUtils.java:
##########
@@ -0,0 +1,125 @@
+/*
Review Comment:
```suggestion
/*
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/
/*
```
<!-- license-eye hidden identification -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org