You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2022/04/29 22:01:23 UTC

[GitHub] [hbase] d-c-manning commented on a diff in pull request #4385: HBASE-26989 TestStochasticLoadBalancer fixes for performance and consistency

d-c-manning commented on code in PR #4385:
URL: https://github.com/apache/hbase/pull/4385#discussion_r862197283


##########
hbase-balancer/src/test/java/org/apache/hadoop/hbase/master/balancer/TestStochasticLoadBalancer.java:
##########
@@ -291,14 +293,15 @@ public void testUpdateStochasticCosts() {
     } finally {
       //reset config
       conf.setFloat("hbase.master.balancer.stochastic.minCostNeedBalance", minCost);
-      conf.unset(HConstants.HBASE_MASTER_LOADBALANCE_BYTABLE);
+      conf.setBoolean(HConstants.HBASE_MASTER_LOADBALANCE_BYTABLE, oldIsByTable);

Review Comment:
   @shahrs87 I can try that. I would probably try it in the base class with a `@Before` annotation to ensure that we restore state before each test.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org