You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/12/16 09:04:00 UTC
[GitHub] [rocketmq] xiaoyifang opened a new issue, #5716: [code bug] the index++ may reach negative value
xiaoyifang opened a new issue, #5716:
URL: https://github.com/apache/rocketmq/issues/5716
https://github.com/apache/rocketmq/blob/adb83ca09633b76150fd3dca294803d96a4dfd60/client/src/main/java/org/apache/rocketmq/client/latency/MQFaultStrategy.java#L61-L63
for example
```
int index=0x7FFFFFFF;
for(int i=0;i<10;i++)
{
System.out.println(index++) ;//will reach negative;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] ShadowySpirits commented on issue #5716: [code bug] the index++ may reach negative value
Posted by GitBox <gi...@apache.org>.
ShadowySpirits commented on issue #5716:
URL: https://github.com/apache/rocketmq/issues/5716#issuecomment-1356089308
Nice catch! And this logic changed in #5181, we should review it again.
https://github.com/apache/rocketmq/pull/5181/files#diff-771f2a9ff3067ee7ec67d5282228514e9e709c549eafe34ae7402b279487d656L87-L93
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [code bug] the index++ may reach negative value [rocketmq]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed issue #5716: [code bug] the index++ may reach negative value
URL: https://github.com/apache/rocketmq/issues/5716
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [code bug] the index++ may reach negative value [rocketmq]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #5716:
URL: https://github.com/apache/rocketmq/issues/5716#issuecomment-1863639841
This issue is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] xiaoyifang commented on issue #5716: [code bug] the index++ may reach negative value
Posted by GitBox <gi...@apache.org>.
xiaoyifang commented on issue #5716:
URL: https://github.com/apache/rocketmq/issues/5716#issuecomment-1357163121
`int index = tpInfo.getSendWhichQueue().incrementAndGet(); `
this line is outside the for loop ,will cause unevenly distributed message just like https://github.com/apache/rocketmq/issues/5672#issuecomment-1357085525 discussed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [code bug] the index++ may reach negative value [rocketmq]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #5716:
URL: https://github.com/apache/rocketmq/issues/5716#issuecomment-1868142866
This issue was closed because it has been inactive for 3 days since being marked as stale.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org