You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/10/13 07:32:48 UTC
[GitHub] [doris] carlvinhust2012 opened a new pull request, #13345: [optimization](array-type) update the docs for import data to array c…
carlvinhust2012 opened a new pull request, #13345:
URL: https://github.com/apache/doris/pull/13345
# Proposed changes
1. this pr is used to update the json load docs for import data to array column.
Issue Number: #7570
## Problem summary
Describe your changes.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [ ] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman merged pull request #13345: [optimization](array-type) update the docs for import data to array c…
Posted by GitBox <gi...@apache.org>.
morningman merged PR #13345:
URL: https://github.com/apache/doris/pull/13345
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] carlvinhust2012 commented on a diff in pull request #13345: [optimization](array-type) update the docs for import data to array c…
Posted by GitBox <gi...@apache.org>.
carlvinhust2012 commented on code in PR #13345:
URL: https://github.com/apache/doris/pull/13345#discussion_r994353603
##########
docs/zh-CN/docs/data-operate/import/import-way/load-json-format.md:
##########
@@ -510,6 +510,47 @@ curl --location-trusted -u user:passwd -H "format: json" -H "jsonpaths: [\"$.id\
105 {"order1":["guangzhou"]} 7
```
+6. 使用json导入Array类型
+由于Rapidjson处理decimal和largeint数值会导致精度问题，所以我们建议使用json字符串来导入数据到array<decimal(27, 9)> 或 array<largeint>列。
Review Comment:
done
##########
docs/zh-CN/docs/data-operate/import/import-way/load-json-format.md:
##########
@@ -510,6 +510,47 @@ curl --location-trusted -u user:passwd -H "format: json" -H "jsonpaths: [\"$.id\
105 {"order1":["guangzhou"]} 7
```
+6. 使用json导入Array类型
+由于Rapidjson处理decimal和largeint数值会导致精度问题，所以我们建议使用json字符串来导入数据到array<decimal(27, 9)> 或 array<largeint>列。
+
+```json
+{"k1": 39, "k2": ["-818.2173181"]}
+```
+
+```json
+{"k1": 40, "k2": ["10000000000000000000.1111111222222222"]}
+```
+
+```bash
+curl --location-trusted -u root: -H "max_filter_ration:0.01" -H "format:json" -H "timeout:300" -T test_decimal.json http://10.81.85.89:8035/api/example_db/array_test_decimal/_stream_load
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #13345: [optimization](array-type) update the docs for import data to array c…
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13345:
URL: https://github.com/apache/doris/pull/13345#issuecomment-1278058367
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #13345: [optimization](array-type) update the docs for import data to array c…
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13345:
URL: https://github.com/apache/doris/pull/13345#issuecomment-1278058319
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] carlvinhust2012 commented on a diff in pull request #13345: [optimization](array-type) update the docs for import data to array c…
Posted by GitBox <gi...@apache.org>.
carlvinhust2012 commented on code in PR #13345:
URL: https://github.com/apache/doris/pull/13345#discussion_r996462489
##########
docs/zh-CN/docs/data-operate/import/import-way/load-json-format.md:
##########
@@ -510,6 +510,47 @@ curl --location-trusted -u user:passwd -H "format: json" -H "jsonpaths: [\"$.id\
105 {"order1":["guangzhou"]} 7
```
+6. 使用json导入Array类型
+由于Rapidjson处理decimal和largeint数值会导致精度问题，所以我们建议使用json字符串来导入数据到array<decimal> 或 array<largeint>列。
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman commented on a diff in pull request #13345: [optimization](array-type) update the docs for import data to array c…
Posted by GitBox <gi...@apache.org>.
morningman commented on code in PR #13345:
URL: https://github.com/apache/doris/pull/13345#discussion_r996460366
##########
docs/en/docs/data-operate/import/import-way/load-json-format.md:
##########
@@ -507,6 +507,48 @@ Import result:
105 {"order1":["guangzhou"]} 7
````
+6. Import Array by json
+Since the Rapidjson handles decimal and largeint numbers which will cause precision problems,
+we suggest you to use json string to import data to array<decimal> or array<largeint> column.
Review Comment:
```suggestion
we suggest you to use json string to import data to `array<decimal>` or `array<largeint>` column.
```
Please modify it, otherwise the `build extension` checks can not be passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] xy720 commented on a diff in pull request #13345: [optimization](array-type) update the docs for import data to array c…
Posted by GitBox <gi...@apache.org>.
xy720 commented on code in PR #13345:
URL: https://github.com/apache/doris/pull/13345#discussion_r994278212
##########
docs/zh-CN/docs/data-operate/import/import-way/load-json-format.md:
##########
@@ -510,6 +510,47 @@ curl --location-trusted -u user:passwd -H "format: json" -H "jsonpaths: [\"$.id\
105 {"order1":["guangzhou"]} 7
```
+6. 使用json导入Array类型
+由于Rapidjson处理decimal和largeint数值会导致精度问题，所以我们建议使用json字符串来导入数据到array<decimal(27, 9)> 或 array<largeint>列。
+
+```json
+{"k1": 39, "k2": ["-818.2173181"]}
+```
+
+```json
+{"k1": 40, "k2": ["10000000000000000000.1111111222222222"]}
+```
+
+```bash
+curl --location-trusted -u root: -H "max_filter_ration:0.01" -H "format:json" -H "timeout:300" -T test_decimal.json http://10.81.85.89:8035/api/example_db/array_test_decimal/_stream_load
Review Comment:
处理脱敏一下ip地址
##########
docs/zh-CN/docs/data-operate/import/import-way/load-json-format.md:
##########
@@ -510,6 +510,47 @@ curl --location-trusted -u user:passwd -H "format: json" -H "jsonpaths: [\"$.id\
105 {"order1":["guangzhou"]} 7
```
+6. 使用json导入Array类型
+由于Rapidjson处理decimal和largeint数值会导致精度问题，所以我们建议使用json字符串来导入数据到array<decimal(27, 9)> 或 array<largeint>列。
Review Comment:
```suggestion
由于Rapidjson处理decimal和largeint数值会导致精度问题，所以我们建议使用json字符串来导入数据到array<decimal> 或 array<largeint>列。
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman commented on a diff in pull request #13345: [optimization](array-type) update the docs for import data to array c…
Posted by GitBox <gi...@apache.org>.
morningman commented on code in PR #13345:
URL: https://github.com/apache/doris/pull/13345#discussion_r996460405
##########
docs/zh-CN/docs/data-operate/import/import-way/load-json-format.md:
##########
@@ -510,6 +510,47 @@ curl --location-trusted -u user:passwd -H "format: json" -H "jsonpaths: [\"$.id\
105 {"order1":["guangzhou"]} 7
```
+6. 使用json导入Array类型
+由于Rapidjson处理decimal和largeint数值会导致精度问题，所以我们建议使用json字符串来导入数据到array<decimal> 或 array<largeint>列。
Review Comment:
```suggestion
由于Rapidjson处理decimal和largeint数值会导致精度问题，所以我们建议使用json字符串来导入数据到`array<decimal>` 或 `array<largeint>`列。
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] carlvinhust2012 commented on a diff in pull request #13345: [optimization](array-type) update the docs for import data to array c…
Posted by GitBox <gi...@apache.org>.
carlvinhust2012 commented on code in PR #13345:
URL: https://github.com/apache/doris/pull/13345#discussion_r996462463
##########
docs/en/docs/data-operate/import/import-way/load-json-format.md:
##########
@@ -507,6 +507,48 @@ Import result:
105 {"order1":["guangzhou"]} 7
````
+6. Import Array by json
+Since the Rapidjson handles decimal and largeint numbers which will cause precision problems,
+we suggest you to use json string to import data to array<decimal> or array<largeint> column.
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org