You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by nakomis <gi...@git.apache.org> on 2014/10/13 18:48:55 UTC

[GitHub] incubator-brooklyn pull request: Fix/entity spec with child

GitHub user nakomis opened a pull request:

    https://github.com/apache/incubator-brooklyn/pull/238

    Fix/entity spec with child

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/nakomis/incubator-brooklyn fix/entity-spec-with-child

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-brooklyn/pull/238.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #238
    
----
commit 66da981c959ca006cf6dc620a1038166c2b7116b
Author: Martin Harris <gi...@nakomis.com>
Date:   2014-10-03T14:58:39Z

    Adds failing (WIP) test for entity spec with child

commit d03e7d40165c0792a8a94a628abddbb0ba73bbd7
Author: Martin Harris <gi...@nakomis.com>
Date:   2014-10-13T16:31:11Z

    Movest the logic for creating child specs from BrooklynAssemblyTemplateInstantiator.resolveSpec to BrooklynComponentTemplateResolver.populateSpec

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Fix/entity spec with child

Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/238#issuecomment-59190424
  
    Looks good. For the record, this PR is to support the `EntitiesYamlTest.testEntitySpecWithChildren` that this PR adds. i.e. where an entity spec defined in yaml has `brooklyn.children` section, then ensure those children are created when an entity is instantiated from the spec.
    
    Merging.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Fix/entity spec with child

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-brooklyn/pull/238


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---