[GitHub] [dolphinscheduler] lordk911 commented on pull request #13064: [BUG][dolphinscheduler-common] OSUtils.getUserListFromLinux cannot work in freeipa managed cluster

[GitBox <gi...@apache.org>]

lordk911 commented on PR #13064:
URL: https://github.com/apache/dolphinscheduler/pull/13064#issuecomment-1334687346

   getUserListFromLinux is a private method
   https://github.com/apache/dolphinscheduler/blob/f5a59982b30e9fdc0f958e1557ae303a19a9c80a/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/OSUtils.java#L199
   
   it used by OSUtils.getUserList 
   
   https://github.com/apache/dolphinscheduler/blob/f5a59982b30e9fdc0f958e1557ae303a19a9c80a/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/OSUtils.java#L178
   
   OSUtils.getUserList only used by TaskExecutionCheckerUtils to check tenant exist 
   
   https://github.com/apache/dolphinscheduler/blob/f5a59982b30e9fdc0f958e1557ae303a19a9c80a/dolphinscheduler-worker/src/main/java/org/apache/dolphinscheduler/server/worker/utils/TaskExecutionCheckerUtils.java#L51
   
   So if we have method to directly check if a user exist on OS , Actually we don't need to get user list from OS.
   
   Another, freeipa is a center servive, if each time the worker server need to get user list from it, I think the pressure on it is no needed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org