[shardingsphere] branch master updated: [Issue #20389]-Improve coverage of CreateProcedureStatementHandler (#20838)

[du...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

duanzhengqiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git


The following commit(s) were added to refs/heads/master by this push:
     new e49bf94c5be [Issue #20389]-Improve coverage of CreateProcedureStatementHandler (#20838)
e49bf94c5be is described below

commit e49bf94c5befed6b4a7bfeae2a87aaaf3d5ce5c7
Author: Abhinav Koppula <ab...@gmail.com>
AuthorDate: Wed Sep 7 11:06:03 2022 +0530

    [Issue #20389]-Improve coverage of CreateProcedureStatementHandler (#20838)
---
 .../handler/ddl/CreateProcedureStatementHandlerTest.java     | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/test/java/org/apache/shardingsphere/sql/parser/sql/dialect/handler/ddl/CreateProcedureStatementHandlerTest.java b/shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/test/java/org/apache/shardingsphere/sql/parser/sql/dialect/handler/ddl/CreateProcedureStatementHandlerTest.java
index 1fbc55cc6db..d815211de21 100644
--- a/shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/test/java/org/apache/shardingsphere/sql/parser/sql/dialect/handler/ddl/CreateProcedureStatementHandlerTest.java
+++ b/shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/test/java/org/apache/shardingsphere/sql/parser/sql/dialect/handler/ddl/CreateProcedureStatementHandlerTest.java
@@ -19,6 +19,10 @@ package org.apache.shardingsphere.sql.parser.sql.dialect.handler.ddl;
 
 import org.apache.shardingsphere.sql.parser.sql.common.segment.ddl.routine.RoutineBodySegment;
 import org.apache.shardingsphere.sql.parser.sql.dialect.statement.mysql.ddl.MySQLCreateProcedureStatement;
+import org.apache.shardingsphere.sql.parser.sql.dialect.statement.opengauss.ddl.OpenGaussCreateProcedureStatement;
+import org.apache.shardingsphere.sql.parser.sql.dialect.statement.oracle.ddl.OracleCreateProcedureStatement;
+import org.apache.shardingsphere.sql.parser.sql.dialect.statement.postgresql.ddl.PostgreSQLCreateProcedureStatement;
+import org.apache.shardingsphere.sql.parser.sql.dialect.statement.sqlserver.ddl.SQLServerCreateProcedureStatement;
 import org.junit.Test;
 
 import java.util.Optional;
@@ -43,4 +47,12 @@ public final class CreateProcedureStatementHandlerTest {
         Optional<RoutineBodySegment> routineBodySegment = CreateProcedureStatementHandler.getRoutineBodySegment(createProcedureStatement);
         assertFalse(routineBodySegment.isPresent());
     }
+    
+    @Test
+    public void assertGetRoutineBodySegmentForOtherDatabases() {
+        assertFalse(CreateProcedureStatementHandler.getRoutineBodySegment(new OpenGaussCreateProcedureStatement()).isPresent());
+        assertFalse(CreateProcedureStatementHandler.getRoutineBodySegment(new OracleCreateProcedureStatement()).isPresent());
+        assertFalse(CreateProcedureStatementHandler.getRoutineBodySegment(new PostgreSQLCreateProcedureStatement()).isPresent());
+        assertFalse(CreateProcedureStatementHandler.getRoutineBodySegment(new SQLServerCreateProcedureStatement()).isPresent());
+    }
 }