[GitHub] [trafficserver] ywkaras opened a new pull request, #8907: Add an ink_mutex destroy function that tolerates the mutex being locked.

[GitBox <gi...@apache.org>]

ywkaras opened a new pull request, #8907:
URL: https://github.com/apache/trafficserver/pull/8907

   Also converts more calls from strerror() to thread-safe ts::Strerror class.
   
   This is hopefully a work-around for crashes that Yahoo prod is seeing on config reload.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] ywkaras closed pull request #8907: Add an ink_mutex destroy function that tolerates the mutex being locked.

[GitBox <gi...@apache.org>]

ywkaras closed pull request #8907: Add an ink_mutex destroy function that tolerates the mutex being locked.
URL: https://github.com/apache/trafficserver/pull/8907


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] ywkaras commented on pull request #8907: Add an ink_mutex destroy function that tolerates the mutex being locked.

[GitBox <gi...@apache.org>]

ywkaras commented on PR #8907:
URL: https://github.com/apache/trafficserver/pull/8907#issuecomment-1155418301

   Yup working on it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] bneradt commented on pull request #8907: Add an ink_mutex destroy function that tolerates the mutex being locked.

[GitBox <gi...@apache.org>]

bneradt commented on PR #8907:
URL: https://github.com/apache/trafficserver/pull/8907#issuecomment-1155398419

   In case it's helpful, here's the Ubuntu build failure:
   https://ci.trafficserver.apache.org/job/Github_Builds/job/ubuntu/1034/console
   
   The linking phase has an undefined reference to `LogMessage::message` in `ink_mutex_safer_destroy`:
   
   ```
   /usr/bin/ld: ../src/tscore/.libs/ink_mutex.o: in function `ink_mutex_safer_destroy(pthread_mutex_t*)':
   /home/jenkins/workspace/Github_Builds/ubuntu/src/out_of_source_build_dir/src/tscore/../../../src/tscore/ink_mutex.cc:87: undefined reference to `LogMessage::message(DiagsLevel, SourceLocation const&, char const*, ...)'
   /usr/bin/ld: /home/jenkins/workspace/Github_Builds/ubuntu/src/out_of_source_build_dir/src/tscore/../../../src/tscore/ink_mutex.cc:87: undefined reference to `LogMessage::LogMessage(bool)'
   libtool: link: ccache clang++ -std=c++17 -g -pipe -Wall -Wno-deprecated-declarations -Qunused-arguments -Wextra -Wno-ignored-qualifiers -Wno-unused-parameter -O3 -fno-strict-aliasing -Werror -Wno-invalid-offsetof -mcx16 -rdynamic -Wl,--as-needed -o traffic_via/.libs/traffic_via traffic_via/traffic_via-traffic_via.o  -L/usr/lib/x86_64-linux-gnu ../src/tscore/.libs/libtscore.so ../src/tscpp/util/.libs/libtscpputil.so -lpcre -lpthread -ldl -Wl,-rpath -Wl,/tmp/ats//lib
   clang: error: linker command failed with exit code 1 (use -v to see invocation)
   make[2]: *** [Makefile:1979: traffic_cache_tool/traffic_cache_tool] Error 1
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org