You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/10/17 02:31:43 UTC

[GitHub] [iceberg] hililiwei commented on pull request #5982: Core: Optimize the TableScanContext

hililiwei commented on PR #5982:
URL: https://github.com/apache/iceberg/pull/5982#issuecomment-1280191676

   > looks great, but I would rename the copy method from `builder` to `from` as I think this is clearer.
   > 
   > @rdblue / @hililiwei I also created #5985 to have a slightly shorter alternative (171 vs 376 LOC) that doesn't require a custom builder.
   
   Thanks fro your review. #5985  Annotations is really more concise.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org