You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@apr.apache.org by Graham Leggett <mi...@sharp.fm> on 2012/03/25 22:36:11 UTC

[VOTE] Release apr-util 1.4.2

Hi all,

Tarballs/zipballs are at http://apr.apache.org/dev/dist/autoconf-2.68+libtool-2.4.2/.

Fixed in apr-util is the static build of the apr_crypto interface. Full CHANGES are here:
https://svn.apache.org/repos/asf/apr/apr-util/tags/1.4.2/CHANGES

+/-1
[  ]  Release apr-util 1.4.2 as GA

Regards,
Graham
--

Re: [VOTE] Release apr-util 1.4.2

Posted by Stefan Fritsch <sf...@sfritsch.de>.
On Monday 02 April 2012, Graham Leggett wrote:
> On 01 Apr 2012, at 11:06 PM, Stefan Fritsch wrote:
> > Sorry for being late, but
> > 
> > -1
> > 
> > Works fine if linked dynamically with DSOs.
> > 
> > But for the static build, httpd segfaults in mod_ssl (backtrace
> > at the bottom of the mail). Since 1.4.1 doesn't compile with
> > 1.4.1 at all, it's hard to say if this is a regression. Have you
> > tried that? I am not sure if it's apr-util's fault or if some of
> > the other libraries produce some strange conflict.
> > 
> > Configure was:
> > 
> > ./configure --with-crypto --with-openssl=/usr --with-nss=/usr
> > --with- dbm=db --with-ldap=yes --with-berkeley-db=/usr
> > --with-pgsql --with- mysql --with-sqlite3 --with-freetds
> > --with-odbc --enable-maintainer- mode
> > --prefix=/usr/local/Aprutil1 --enable-nonportable-atomics --
> > enable-threads --enable-allocator-uses-mmap
> > --with-apr=/usr/bin/apr- config CFLAGS= -gdwarf-2 -g3 -Wextra
> > -Wno-unused-parameter -Wno- missing-field-initializers
> > -Wno-sign-compare -Werror=declaration- after-statement
> > --disable-util-dso
> > configure: WARNING: unrecognized options:
> > --enable-maintainer-mode, -- enable-nonportable-atomics,
> > --enable-threads, --enable-allocator-uses- mmap
> 
> Would it be possible to reduce this down to a reproducible set of
> configure options? The unrecognised options seem strange, as does
> "--with-apr=/usr/bin/apr-config" (shouldn't it be apr-1-config?).
> What options did you use to try and build httpd?
> 
> Given that static builds have in the past not worked at all, this
> isn't a regression. I just discovered static builds of DSO code
> were broken on apr-trunk and have been for some time, so any
> improvement is a step forward.

When I wrote that, I could reproduce it also with a minimal configure 
command, as long as mod_session_crypto was loaded. But I can't 
reproduce it now. Maybe it was fixed by r1308135.

> > If configured statically but without openssl, it doesn't compile:
> > 
> > crypto/apr_crypto.c: In function 'apr_crypto_get_driver':
> > crypto/apr_crypto.c:227:5: error: 'else' without a previous 'if'
> > make[1]: *** [crypto/apr_crypto.lo] Fehler 1
> 
> This is definitely a bug, fixed in r1308318.

Thanks. That was the main reason for my -1.

Re: [VOTE] Release apr-util 1.4.2

Posted by Graham Leggett <mi...@sharp.fm>.
On 01 Apr 2012, at 11:06 PM, Stefan Fritsch wrote:

> Sorry for being late, but
> 
> -1
> 
> Works fine if linked dynamically with DSOs.
> 
> But for the static build, httpd segfaults in mod_ssl (backtrace at the 
> bottom of the mail). Since 1.4.1 doesn't compile with 1.4.1 at all, 
> it's hard to say if this is a regression. Have you tried that? I am 
> not sure if it's apr-util's fault or if some of the other libraries 
> produce some strange conflict.
> 
> Configure was:
> 
> ./configure --with-crypto --with-openssl=/usr --with-nss=/usr --with-
> dbm=db --with-ldap=yes --with-berkeley-db=/usr --with-pgsql --with-
> mysql --with-sqlite3 --with-freetds --with-odbc --enable-maintainer-
> mode --prefix=/usr/local/Aprutil1 --enable-nonportable-atomics --
> enable-threads --enable-allocator-uses-mmap --with-apr=/usr/bin/apr-
> config CFLAGS= -gdwarf-2 -g3 -Wextra -Wno-unused-parameter -Wno-
> missing-field-initializers -Wno-sign-compare -Werror=declaration-
> after-statement --disable-util-dso
> configure: WARNING: unrecognized options: --enable-maintainer-mode, --
> enable-nonportable-atomics, --enable-threads, --enable-allocator-uses-
> mmap

Would it be possible to reduce this down to a reproducible set of configure options? The unrecognised options seem strange, as does "--with-apr=/usr/bin/apr-config" (shouldn't it be apr-1-config?). What options did you use to try and build httpd?

Given that static builds have in the past not worked at all, this isn't a regression. I just discovered static builds of DSO code were broken on apr-trunk and have been for some time, so any improvement is a step forward.

> If configured statically but without openssl, it doesn't compile:
> 
> crypto/apr_crypto.c: In function 'apr_crypto_get_driver':
> crypto/apr_crypto.c:227:5: error: 'else' without a previous 'if'
> make[1]: *** [crypto/apr_crypto.lo] Fehler 1

This is definitely a bug, fixed in r1308318.

> According to CHANGES, the only change is to fix static build, and it 
> fails at that. Therefore the -1.

Just to set expectations, the change in v1.4.2 wasn't to "fix the static build", but rather to fix a specific compile error during static build that was affecting the Windows people:

  *) apr_crypto: Move the static initialisation of DRIVER_LOAD from
     apr_crypto_init() to apr_crypto_get_driver(), so that we don't lose
     the parameters. [Graham Leggett]

As I pointed out to Greg, I plan to reroll to take into account the fixes from the last few days.

Regards,
Graham
--

Re: [VOTE] Release apr-util 1.4.2

Posted by Stefan Fritsch <sf...@sfritsch.de>.
On Sunday 25 March 2012, Graham Leggett wrote:
> Fixed in apr-util is the static build of the apr_crypto interface.
> Full CHANGES are here:
> https://svn.apache.org/repos/asf/apr/apr-util/tags/1.4.2/CHANGES
> 
> +/-1
> [ ]  Release apr-util 1.4.2 as GA

Sorry for being late, but

-1

Works fine if linked dynamically with DSOs.

But for the static build, httpd segfaults in mod_ssl (backtrace at the 
bottom of the mail). Since 1.4.1 doesn't compile with 1.4.1 at all, 
it's hard to say if this is a regression. Have you tried that? I am 
not sure if it's apr-util's fault or if some of the other libraries 
produce some strange conflict.

Configure was:

./configure --with-crypto --with-openssl=/usr --with-nss=/usr --with-
dbm=db --with-ldap=yes --with-berkeley-db=/usr --with-pgsql --with-
mysql --with-sqlite3 --with-freetds --with-odbc --enable-maintainer-
mode --prefix=/usr/local/Aprutil1 --enable-nonportable-atomics --
enable-threads --enable-allocator-uses-mmap --with-apr=/usr/bin/apr-
config CFLAGS= -gdwarf-2 -g3 -Wextra -Wno-unused-parameter -Wno-
missing-field-initializers -Wno-sign-compare -Werror=declaration-
after-statement --disable-util-dso
configure: WARNING: unrecognized options: --enable-maintainer-mode, --
enable-nonportable-atomics, --enable-threads, --enable-allocator-uses-
mmap


If configured statically but without openssl, it doesn't compile:

crypto/apr_crypto.c: In function 'apr_crypto_get_driver':
crypto/apr_crypto.c:227:5: error: 'else' without a previous 'if'
make[1]: *** [crypto/apr_crypto.lo] Fehler 1

According to CHANGES, the only change is to fix static build, and it 
fails at that. Therefore the -1.




Program terminated with signal 11, Segmentation fault.
#0  0xf5c34140 in ?? ()
(gdb) bt full
#0  0xf5c34140 in ?? ()
No symbol table info available.
#1  0xf73062f0 in int_free_ex_data (class_index=10, obj=0x8db1848, 
ad=0x8db1860) at ex_data.c:522
        mx = 1
        i = <optimized out>
        item = 0x8dc5558
        ptr = <optimized out>
        storage = 0x1
#2  0xf7306063 in CRYPTO_free_ex_data (class_index=10, obj=0x8db1848, 
ad=0x8db1860) at ex_data.c:592
No locals.
#3  0xf73a023f in x509_cb (operation=3, pval=0xffb07870, 
it=0xf7465d3c, exarg=0x0) at x_x509.c:113
        ret = 0x8db1848
#4  0xf73a573c in asn1_item_combine_free (pval=<optimized out>, 
it=<optimized out>, combine=0) at tasn_fre.c:173
        tt = <optimized out>
        seqtt = <optimized out>
        ef = <optimized out>
        cf = <optimized out>
        aux = <optimized out>
        asn1_cb = <optimized out>
        i = <optimized out>
#5  0xf73a5957 in ASN1_item_free (val=0x8db1848, it=0xf7465d3c) at 
tasn_fre.c:71
No locals.
#6  0xf73a0465 in X509_free (a=0x8db1848) at x_x509.c:141
No locals.
#7  0xf5d8eff3 in ssl_pphrase_Handle (s=0xf67df3e8, p=0xf67a7018) at 
ssl_engine_pphrase.c:275
        key_id = 0xf5a07f08 "localhost:8534:RSA"
        using_cache = <optimized out>
        mc = 0xf7768ce0
        sc = 0xf5ab3788
        pServ = 0xf5ab5388
        cpVHostID = 0xf596c8f8 "localhost:8534"
        szPath = "/home/stf/apache/perl-
framework/t/conf/ssl/ca/asf/certs/server.crt\000õ\000 \000\000hÈ\226õ 
'\230õ\220Ã\177öì×n÷ty°ÿ`\bz÷å´~öø×n÷ôßz÷@'\230õå´~öð{°ÿ\000-
conference/x-
cooltalk\t\t\t\tice\000\000.mov\000\000ia\000\000in\000\000\000\000 
w3d fgd swa\000\000signature+xml\000\000xml"...
        pPrivateKey = <optimized out>
        asn1 = <optimized out>
        ucp = 0x8dc52f5 "ó&Ùmvgç\231\001"
        length = <optimized out>
        pX509Cert = 0x8db1848
        bReadable = <optimized out>
        aPassPhrase = 0xf596c8b8
        nPassPhrase = 0
        nPassPhraseCur = 134815315
        cpPassPhraseCur = 0x6 <Address 0x6 out of bounds>
        nPassPhraseRetry = <optimized out>
        nPassPhraseDialog = 0
        nPassPhraseDialogCur = 10114
        bPassPhraseDialogOnce = 0
        cpp = <optimized out>
        i = 0
        j = <optimized out>
        algoCert = 1
        algoKey = <optimized out>
        at = 1
        an = 0xf5d9ebfa "RSA"
        pkey_mtime = 0
        rv = <optimized out>
#8  0xf5d85f76 in ssl_init_Module (p=0xf7787018, plog=0xf67ad018, 
ptemp=0xf67a7018, base_server=0xf67df3e8)
    at ssl_engine_init.c:322
        mc = <optimized out>
        sc = 0xf5b89a50
        s = <optimized out>
#9  0x0808c399 in ap_run_post_config (pconf=0xf7787018, 
plog=0xf67ad018, ptemp=0xf67a7018, s=0xf67df3e8) at config.c:105
        pHook = <optimized out>
        n = <optimized out>
        rv = 0
#10 0x0806d3ad in main (argc=9, argv=0xffb09b24) at main.c:765
        c = 68 'D'
        showcompile = 0
        showdirectives = 0
        confname = 0xffb0b20d "/home/stf/apache/perl-
framework/t/conf/httpd.conf"
        def_server_root = 0xffb0b1e8 "/home/stf/apache/perl-
framework/t"
        temp_error_log = 0x0
        error = <optimized out>
        process = 0xf77890a8
        pconf = 0xf7787018
        plog = 0xf67ad018
        ptemp = 0xf67a7018
        pcommands = 0xf67e1018
        opt = 0xf67e10b8
        rv = <optimized out>
        mod = 0x80c0d6c
        opt_arg = 0xffb0b24d "PERL_USEITHREADS"
        signal_server = <optimized out>

Re: [VOTE] Release apr-util 1.4.2

Posted by Jeff Trawick <tr...@gmail.com>.
On Fri, Mar 30, 2012 at 4:33 PM, Jeff Trawick <tr...@gmail.com> wrote:
> On Sun, Mar 25, 2012 at 4:36 PM, Graham Leggett <mi...@sharp.fm> wrote:
>> Hi all,
>>
>> Tarballs/zipballs are at http://apr.apache.org/dev/dist/autoconf-2.68+libtool-2.4.2/.
>>
>> Fixed in apr-util is the static build of the apr_crypto interface. Full CHANGES are here:
>> https://svn.apache.org/repos/asf/apr/apr-util/tags/1.4.2/CHANGES
>>
>> +/-1
>> [  ]  Release apr-util 1.4.2 as GA
>
> Hopefully I can test tomorrow.

[+1]  Release apr-util 1.4.2 as GA

I tested on Linux only, but a diff of the tarball and zipball against
1.4.1 didn't show any areas of concern.

Re: [VOTE] Release apr-util 1.4.2

Posted by Jeff Trawick <tr...@gmail.com>.
On Sun, Mar 25, 2012 at 4:36 PM, Graham Leggett <mi...@sharp.fm> wrote:
> Hi all,
>
> Tarballs/zipballs are at http://apr.apache.org/dev/dist/autoconf-2.68+libtool-2.4.2/.
>
> Fixed in apr-util is the static build of the apr_crypto interface. Full CHANGES are here:
> https://svn.apache.org/repos/asf/apr/apr-util/tags/1.4.2/CHANGES
>
> +/-1
> [  ]  Release apr-util 1.4.2 as GA

Hopefully I can test tomorrow.

Re: [VOTE] Release apr-util 1.4.2

Posted by Bojan Smojver <bo...@rexursive.com>.
On Sun, 2012-03-25 at 22:36 +0200, Graham Leggett wrote:
> [+1]  Release apr-util 1.4.2 as GA

All tests pass on F-16, x86_64, with and without --disable-util-dso.
Good signature and checksums.

-- 
Bojan

Re: [VOTE] Release apr-util 1.4.2

Posted by Graham Leggett <mi...@sharp.fm>.
On 25 Mar 2012, at 10:36 PM, Graham Leggett wrote:

> Tarballs/zipballs are at http://apr.apache.org/dev/dist/autoconf-2.68+libtool-2.4.2/.
> 
> Fixed in apr-util is the static build of the apr_crypto interface. Full CHANGES are here:
> https://svn.apache.org/repos/asf/apr/apr-util/tags/1.4.2/CHANGES
> 
> +/-1
> [  ]  Release apr-util 1.4.2 as GA

Builds clean and all tests pass on FC17, MacOSX and CentOS6.

+1.

Regards,
Graham
--

Re: [VOTE] Release apr-util 1.4.2

Posted by Jeff Trawick <tr...@gmail.com>.
On Sun, Mar 25, 2012 at 4:36 PM, Graham Leggett <mi...@sharp.fm> wrote:
> Hi all,
>
> Tarballs/zipballs are at http://apr.apache.org/dev/dist/autoconf-2.68+libtool-2.4.2/.
>
> Fixed in apr-util is the static build of the apr_crypto interface. Full CHANGES are here:
> https://svn.apache.org/repos/asf/apr/apr-util/tags/1.4.2/CHANGES
>
> +/-1
> [  ]  Release apr-util 1.4.2 as GA

I didn't find a statement on the mailing list (bad search?), but
obviously 1.4.2 is not being released.