You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by "JiajunBernoulli (via GitHub)" <gi...@apache.org> on 2023/08/19 08:37:55 UTC

[GitHub] [calcite] JiajunBernoulli commented on a diff in pull request #3378: [CALCITE-5770] Add SAFE_SUBTRACT function (enabled in BigQuery library)

JiajunBernoulli commented on code in PR #3378:
URL: https://github.com/apache/calcite/pull/3378#discussion_r1299156932


##########
babel/src/test/resources/sql/big-query.iq:
##########
@@ -668,6 +668,77 @@ SELECT SAFE_ADD(CAST('NaN' AS DOUBLE), CAST(3 as BIGINT)) as NaN_result;
 (1 row)
 
 !ok
+
+#####################################################################
+# SAFE_DIVIDE
+#
+# SAFE_DIVIDE(value1, value2)

Review Comment:
   Can we have some tests with some expression parameters?
   
   `SAFE_DIVIDE(1*1, 1-1)`
   `SAFE_DIVIDE(1, 1/9223372036854775807)`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org