You are viewing a plain text version of this content. The canonical link for it is here.

Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2022/04/12 19:20:51 UTC

[GitHub] [hive] scarlin-cloudera commented on a diff in pull request #3179: HIVE-26117: Remove 2 superfluous lines of code in genJoinRelNode

scarlin-cloudera commented on code in PR #3179:
URL: https://github.com/apache/hive/pull/3179#discussion_r848792227


##########
ql/src/test/results/clientnegative/joinneg.q.out:
##########
@@ -1 +1 @@
-FAILED: SemanticException [Error 10004]: Line 6:12 Invalid table alias or column reference 'b': (possible column names are: x.key, x.value, y.key, y.value)
+FAILED: SemanticException [Error 10009]: Line 6:12 Invalid table alias 'b'

Review Comment:
   Agreed, but I think that's an issue for the new code.  I would rather remove the lines of code that converts to ExprNodes (but keep the unparsetranslator part.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org