You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/09/10 15:57:21 UTC
[GitHub] [apisix] membphis opened a new pull request #2211: bugfix: use the route's `has_domain` attribute if the route contains upstream object
membphis opened a new pull request #2211:
URL: https://github.com/apache/apisix/pull/2211
### What this PR does / why we need it:
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->
step:
1. create a route with an upstream object, and the upstream node contains domain.
2. create a service, no upstream object (eg: only `plugins`).
client request will fail, we will got `502`, because the domain of the upstream node is not parsed by DNS resolver.
fix way:
as title.
### Pre-submission checklist:
* [ ] Did you explain what problem does this PR solve? Or what new features have been added?
* [ ] Have you added corresponding test cases?
* [ ] Have you modified the corresponding document?
* [ ] Is this PR backward compatible?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] gxthrj commented on pull request #2211: bugfix: use the route's `has_domain` attribute if the route contains upstream object
Posted by GitBox <gi...@apache.org>.
gxthrj commented on pull request #2211:
URL: https://github.com/apache/apisix/pull/2211#issuecomment-690432265
some checks failed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] shuaijinchao commented on pull request #2211: bugfix: use the route's `has_domain` attribute if the route contains upstream object
Posted by GitBox <gi...@apache.org>.
shuaijinchao commented on pull request #2211:
URL: https://github.com/apache/apisix/pull/2211#issuecomment-692425998
Follow-up can support dynamic upstream according to request information, cool.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] membphis commented on pull request #2211: bugfix: use the route's `has_domain` attribute if the route contains upstream object
Posted by GitBox <gi...@apache.org>.
membphis commented on pull request #2211:
URL: https://github.com/apache/apisix/pull/2211#issuecomment-690463565
> some checks failed
fail to access GitHub, it should be a network problem. rerun it again.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] moonming merged pull request #2211: bugfix: use the route's `has_domain` attribute if the route contains upstream object
Posted by GitBox <gi...@apache.org>.
moonming merged pull request #2211:
URL: https://github.com/apache/apisix/pull/2211
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org