You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/12/30 22:16:52 UTC
[GitHub] [kafka] mjsax opened a new pull request #9801: MINOR: code cleanup for Kafka Streams task interface
mjsax opened a new pull request #9801:
URL: https://github.com/apache/kafka/pull/9801
Not functional change. Pure code cleanup.
Call for review @vvcephei (cf. #8852 -- will split up the old PR into multiple smaller ones to simplify reviewing)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mjsax commented on a change in pull request #9801: MINOR: code cleanup for Kafka Streams task interface
Posted by GitBox <gi...@apache.org>.
mjsax commented on a change in pull request #9801:
URL: https://github.com/apache/kafka/pull/9801#discussion_r550342638
##########
File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/AbstractTask.java
##########
@@ -124,11 +124,6 @@ public StateStore getStore(final String name) {
return stateMgr.getStore(name);
}
- @Override
- public boolean isClosed() {
Review comment:
This method is unused. Removing it.
##########
File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/AbstractTask.java
##########
@@ -154,7 +149,7 @@ final void transitionTo(final Task.State newState) {
}
@Override
- public void update(final Set<TopicPartition> topicPartitions, final Map<String, List<String>> allTopologyNodesToSourceTopics) {
+ public void updateInputPartitions(final Set<TopicPartition> topicPartitions, final Map<String, List<String>> allTopologyNodesToSourceTopics) {
Review comment:
Renaming to get better name.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mjsax merged pull request #9801: MINOR: code cleanup for Kafka Streams task interface
Posted by GitBox <gi...@apache.org>.
mjsax merged pull request #9801:
URL: https://github.com/apache/kafka/pull/9801
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mjsax commented on a change in pull request #9801: MINOR: code cleanup for Kafka Streams task interface
Posted by GitBox <gi...@apache.org>.
mjsax commented on a change in pull request #9801:
URL: https://github.com/apache/kafka/pull/9801#discussion_r550342917
##########
File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/Task.java
##########
@@ -98,17 +98,9 @@ public boolean isValidTransition(final State newState) {
}
}
- TaskId id();
Review comment:
Group and order methods (no functional change)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mjsax commented on a change in pull request #9801: MINOR: code cleanup for Kafka Streams task interface
Posted by GitBox <gi...@apache.org>.
mjsax commented on a change in pull request #9801:
URL: https://github.com/apache/kafka/pull/9801#discussion_r550342976
##########
File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/Task.java
##########
@@ -98,17 +98,9 @@ public boolean isValidTransition(final State newState) {
}
}
- TaskId id();
-
- State state();
-
- default boolean needsInitializationOrRestoration() {
- return state() == State.CREATED || state() == State.RESTORING;
- }
- boolean isActive();
- boolean isClosed();
Review comment:
This method is removed because it's unused.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org