You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "hiroyuki-sato (via GitHub)" <gi...@apache.org> on 2025/05/12 01:41:47 UTC
[PR] GH-46400: [GLib] Add GArrowFixedShapeDataType#permutation [arrow]
hiroyuki-sato opened a new pull request, #46401:
URL: https://github.com/apache/arrow/pull/46401
### Rationale for this change
The C++ API implemented `FixedShapeTensor::permutation()` instance method. GLib was not yet supported.
### What changes are included in this PR?
Add `GArrowFixedShapeDataType#permutation` instance method.
### Are these changes tested?
Yes.
### Are there any user-facing changes?
Yes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46400: [GLib] Add GArrowFixedShapeDataType#permutation [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #46401:
URL: https://github.com/apache/arrow/pull/46401#discussion_r2083702200
##########
c_glib/arrow-glib/basic-data-type.cpp:
##########
@@ -2366,6 +2366,24 @@ garrow_fixed_shape_tensor_data_type_get_shape(GArrowFixedShapeTensorDataType *da
return arrow_shape.data();
}
+/**
+ * garrow_fixed_shape_tensor_data_type_get_permutation:
+ * @data_type: A #GArrowFixedShapeTensorDataType.
+ * @length: (out): Return location for the number of dimensions of the tensor.
Review Comment:
Could you update this comment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46400: [GLib] Add GArrowFixedShapeDataType#permutation [arrow]
Posted by "hiroyuki-sato (via GitHub)" <gi...@apache.org>.
hiroyuki-sato commented on PR #46401:
URL: https://github.com/apache/arrow/pull/46401#issuecomment-2874793884
@kou Thank you for your review. Suggested change applied.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46400: [GLib] Add GArrowFixedShapeDataType#permutation [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #46401:
URL: https://github.com/apache/arrow/pull/46401#discussion_r2083714932
##########
c_glib/arrow-glib/basic-data-type.cpp:
##########
@@ -2366,6 +2366,24 @@ garrow_fixed_shape_tensor_data_type_get_shape(GArrowFixedShapeTensorDataType *da
return arrow_shape.data();
}
+/**
+ * garrow_fixed_shape_tensor_data_type_get_permutation:
+ * @data_type: A #GArrowFixedShapeTensorDataType.
+ * @length: (out): Return location for the number of permutations of the tensor.
Review Comment:
```suggestion
* @length: (out): Return location for the number of elements of permutation.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46400: [GLib] Add GArrowFixedShapeDataType#permutation [arrow]
Posted by "hiroyuki-sato (via GitHub)" <gi...@apache.org>.
hiroyuki-sato commented on code in PR #46401:
URL: https://github.com/apache/arrow/pull/46401#discussion_r2083704842
##########
c_glib/arrow-glib/basic-data-type.cpp:
##########
@@ -2366,6 +2366,24 @@ garrow_fixed_shape_tensor_data_type_get_shape(GArrowFixedShapeTensorDataType *da
return arrow_shape.data();
}
+/**
+ * garrow_fixed_shape_tensor_data_type_get_permutation:
+ * @data_type: A #GArrowFixedShapeTensorDataType.
+ * @length: (out): Return location for the number of dimensions of the tensor.
Review Comment:
Ah, Thanks. Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46400: [GLib] Add GArrowFixedShapeDataType#permutation [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #46401:
URL: https://github.com/apache/arrow/pull/46401#issuecomment-2870480236
:warning: GitHub issue #46400 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46400: [GLib] Add GArrowFixedShapeDataType#permutation [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #46401:
URL: https://github.com/apache/arrow/pull/46401#issuecomment-2875910133
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 9a66bdccc378e9f8a0cf94ad4e65e44a735d0ebe.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/42124271026) has more details. It also includes information about 24 possible false positives for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46400: [GLib] Add GArrowFixedShapeDataType#permutation [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #46401:
URL: https://github.com/apache/arrow/pull/46401
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org