You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "apupier (via GitHub)" <gi...@apache.org> on 2026/03/09 10:56:46 UTC
[PR] AVRO-4191 - include tests on JDK 25 [avro]
apupier opened a new pull request, #3685:
URL: https://github.com/apache/avro/pull/3685
<!--
*Thank you very much for contributing to Apache Avro - we are happy that you want to help us improve Avro. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Avro a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/AVRO/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "AVRO-XXXX: [component] Title of the pull request", where *AVRO-XXXX* should be replaced by the actual issue number.
The *component* is optional, but can help identify the correct reviewers faster: either the language ("java", "python") or subsystem such as "build" or "doc" are good candidates.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests. You can [build the entire project](https://github.com/apache/avro/blob/main/BUILD.md) or just the [language-specific SDK](https://avro.apache.org/project/how-to-contribute/#unit-tests).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Every commit message references Jira issues in their subject lines. In addition, commits follow the guidelines from [How to write a good git commit message](https://chris.beams.io/posts/git-commit/)
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
-->
## What is the purpose of the change
*(For example: This pull request improves file read performance by buffering data, fixing AVRO-XXXX.)*
## Verifying this change
*(Please pick one of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Extended interop tests to verify consistent valid schema names between SDKs*
- *Added test that validates that Java throws an AvroRuntimeException on invalid binary data*
- *Manually verified the change by building the website and checking the new redirect*
## Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] AVRO-4191 - include tests on JDK 25 [avro]
Posted by "martin-g (via GitHub)" <gi...@apache.org>.
martin-g commented on PR #3685:
URL: https://github.com/apache/avro/pull/3685#issuecomment-4022915388
For some reason the Java SDK build and tests are not triggered ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] AVRO-4191 - include tests on JDK 25 [avro]
Posted by "apupier (via GitHub)" <gi...@apache.org>.
apupier commented on PR #3685:
URL: https://github.com/apache/avro/pull/3685#issuecomment-4023236769
I do not think that we can use a matrix easily as the minimal Java version to do the compilation is JDK 21 but tests are launched with several JDKs versions. it is launched with different Maven execution directly defined in the pom.xml. Each version si picked from the toolchains.xml whcih is configured by the
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] AVRO-4191 - include tests on JDK 25 [avro]
Posted by "apupier (via GitHub)" <gi...@apache.org>.
apupier commented on PR #3685:
URL: https://github.com/apache/avro/pull/3685#issuecomment-5091085419
updated and rebased to resolve conflicts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] AVRO-4191 - include tests on JDK 25 [avro]
Posted by "martin-g (via GitHub)" <gi...@apache.org>.
martin-g closed pull request #3685: AVRO-4191 - include tests on JDK 25
URL: https://github.com/apache/avro/pull/3685
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] AVRO-4191 - include tests on JDK 25 [avro]
Posted by "martin-g (via GitHub)" <gi...@apache.org>.
martin-g commented on code in PR #3685:
URL: https://github.com/apache/avro/pull/3685#discussion_r2905006412
##########
.github/workflows/codeql-java-analysis.yml:
##########
Review Comment:
Honestly, I have no idea what this job is supposed to do. It just installs several versions of the JDK and let's the OS decides which one to use as a default.
Does CodeQL need several SDKs to do its job ?!
Leaving just one of them should be the same.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] AVRO-4191 - include tests on JDK 25 [avro]
Posted by "apupier (via GitHub)" <gi...@apache.org>.
apupier commented on code in PR #3685:
URL: https://github.com/apache/avro/pull/3685#discussion_r2904993490
##########
.github/workflows/codeql-java-analysis.yml:
##########
Review Comment:
need to update the naming too if we remove the 8 and 11 from the test matrix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] AVRO-4191 - include tests on JDK 25 [avro]
Posted by "apupier (via GitHub)" <gi...@apache.org>.
apupier commented on PR #3685:
URL: https://github.com/apache/avro/pull/3685#issuecomment-4023537149
> > I do not think that we can use a matrix easily as the minimal Java version to do the compilation is JDK 21 but tests are launched with several JDKs versions. it is launched with different Maven execution directly defined in the pom.xml. Each version si picked from the toolchains.xml whcih is configured by the
>
> OK! I'll leave it to you. I haven't touched the Java SDK for a long time and obviously I have forgotten how it works. Please revert whatever is needed.
in fact, there are 2 ways of doing it.
Either set the minimal version to Java 17, use a matrix job and keep a single execution.
Or rely on toolchains. it is a bit more advanced, I think it will save time on Ci and it forces to have test splayed locally with all jdk by default. The downside is that it is more complicated to setup and seems that even committers on the project do not remember it.
So I think I will remove the different executions and reliance on the toolchain. (especially when I see that the jobs are already green now, it is just that we are playing the same tests several times with same JDKs and we cna go a bit faster)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] AVRO-4191 - include tests on JDK 25 [avro]
Posted by "martin-g (via GitHub)" <gi...@apache.org>.
martin-g commented on PR #3685:
URL: https://github.com/apache/avro/pull/3685#issuecomment-4023281104
> I do not think that we can use a matrix easily as the minimal Java version to do the compilation is JDK 21 but tests are launched with several JDKs versions. it is launched with different Maven execution directly defined in the pom.xml. Each version si picked from the toolchains.xml whcih is configured by the
OK!
I'll leave it to you. I haven't touched the Java SDK for a long time and obviously I have forgotten how it works.
Please revert whatever is needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] AVRO-4191 - include tests on JDK 25 [avro]
Posted by "apupier (via GitHub)" <gi...@apache.org>.
apupier commented on PR #3685:
URL: https://github.com/apache/avro/pull/3685#issuecomment-4023784420
it is surely possible to save the time mentioned here https://github.com/apache/avro/actions/runs/22854799208/job/66292172522?pr=3685#step:8:839 but to be honest, not sure it is worthy to take the risk to change too many things. The current PR should be enough as a first iteration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org