You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/05/10 16:16:41 UTC
[GitHub] [superset] eschutho commented on a diff in pull request #19983: feat: save active tabs in dashboard permalink
eschutho commented on code in PR #19983:
URL: https://github.com/apache/superset/pull/19983#discussion_r869444023
##########
superset-frontend/src/dashboard/actions/hydrate.js:
##########
@@ -338,7 +336,9 @@ export const hydrateDashboard =
}
const { roles } = user;
- const canEdit = canUserEditDashboard(dashboardData, user);
+ const canEdit = canUserEditDashboard(dashboard, user);
+
+ console.log(activeTabs);
Review Comment:
left over console log
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org