You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/10/25 13:08:07 UTC
[GitHub] [shardingsphere] pandaapo opened a new pull request, #21753: fix issue: add MySQL data type, linestring.
pandaapo opened a new pull request, #21753:
URL: https://github.com/apache/shardingsphere/pull/21753
Fixes #21751.
Changes proposed in this pull request:
- Add a MySQL data type, linestring. Map it to binary.
---
Before committing this PR, I'm sure that I have checked the following options:
- [x] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [x] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [ ] I have passed maven check locally : `mvn clean install -B -T2C -DskipTests -Dmaven.javadoc.skip=true -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] pandaapo commented on pull request #21753: fix issue: add MySQL data type, linestring.
Posted by GitBox <gi...@apache.org>.
pandaapo commented on PR #21753:
URL: https://github.com/apache/shardingsphere/pull/21753#issuecomment-1291896020
@sandynz Could you review this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] sandynz merged pull request #21753: fix issue: add MySQL data type, linestring.
Posted by GitBox <gi...@apache.org>.
sandynz merged PR #21753:
URL: https://github.com/apache/shardingsphere/pull/21753
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] sandynz commented on a diff in pull request #21753: fix issue: add MySQL data type, linestring.
Posted by GitBox <gi...@apache.org>.
sandynz commented on code in PR #21753:
URL: https://github.com/apache/shardingsphere/pull/21753#discussion_r1006337343
##########
infra/common/src/main/java/org/apache/shardingsphere/infra/metadata/database/schema/loader/dialect/datatypeloader/MySQLDataTypeLoader.java:
##########
@@ -46,6 +46,7 @@ public Map<String, Integer> load(final DatabaseMetaData database) throws SQLExce
result.putIfAbsent("POLYGON", Types.BINARY);
result.putIfAbsent("MULTIPOLYGON", Types.BINARY);
result.putIfAbsent("MULTILINESTRING", Types.BINARY);
+ result.putIfAbsent("LINESTRING", Types.BINARY);
Review Comment:
1, It's better to put `LINESTRING` before `MULTILINESTRING`;
2, From the doc, looks there's `GEOMETRYCOLLECTION`, could it add here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] pandaapo commented on pull request #21753: fix issue: add MySQL data type, linestring.
Posted by GitBox <gi...@apache.org>.
pandaapo commented on PR #21753:
URL: https://github.com/apache/shardingsphere/pull/21753#issuecomment-1292063167
> Hi @pandaapo , could you supply: 1) related MySQL document link, 2) local test table structure and result
[MySQL Reference Manual](https://dev.mysql.com/doc/refman/5.6/en/spatial-type-overview.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] pandaapo commented on a diff in pull request #21753: fix issue: add MySQL data type, linestring.
Posted by GitBox <gi...@apache.org>.
pandaapo commented on code in PR #21753:
URL: https://github.com/apache/shardingsphere/pull/21753#discussion_r1006344454
##########
infra/common/src/main/java/org/apache/shardingsphere/infra/metadata/database/schema/loader/dialect/datatypeloader/MySQLDataTypeLoader.java:
##########
@@ -46,6 +46,7 @@ public Map<String, Integer> load(final DatabaseMetaData database) throws SQLExce
result.putIfAbsent("POLYGON", Types.BINARY);
result.putIfAbsent("MULTIPOLYGON", Types.BINARY);
result.putIfAbsent("MULTILINESTRING", Types.BINARY);
+ result.putIfAbsent("LINESTRING", Types.BINARY);
Review Comment:
OK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #21753: fix issue: add MySQL data type, linestring.
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #21753:
URL: https://github.com/apache/shardingsphere/pull/21753#issuecomment-1292998324
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/21753?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#21753](https://codecov.io/gh/apache/shardingsphere/pull/21753?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a8f3bc8) into [master](https://codecov.io/gh/apache/shardingsphere/commit/5c247ec28388c26818651a5269403567ccbb76b0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5c247ec) will **decrease** coverage by `0.26%`.
> The diff coverage is `63.04%`.
```diff
@@ Coverage Diff @@
## master #21753 +/- ##
============================================
- Coverage 61.06% 60.79% -0.27%
+ Complexity 2497 2446 -51
============================================
Files 4110 4118 +8
Lines 57386 57478 +92
Branches 9697 9693 -4
============================================
- Hits 35042 34946 -96
- Misses 19433 19627 +194
+ Partials 2911 2905 -6
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/21753?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...erter/DatabaseDiscoveryRuleStatementConverter.java](https://codecov.io/gh/apache/shardingsphere/pull/21753/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvZGItZGlzY292ZXJ5L2Rpc3RzcWwvaGFuZGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGJkaXNjb3ZlcnkvZGlzdHNxbC9oYW5kbGVyL2NvbnZlcnRlci9EYXRhYmFzZURpc2NvdmVyeVJ1bGVTdGF0ZW1lbnRDb252ZXJ0ZXIuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...te/AlterDatabaseDiscoveryRuleStatementUpdater.java](https://codecov.io/gh/apache/shardingsphere/pull/21753/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvZGItZGlzY292ZXJ5L2Rpc3RzcWwvaGFuZGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGJkaXNjb3ZlcnkvZGlzdHNxbC9oYW5kbGVyL3VwZGF0ZS9BbHRlckRhdGFiYXNlRGlzY292ZXJ5UnVsZVN0YXRlbWVudFVwZGF0ZXIuamF2YQ==) | `86.95% <ø> (+0.16%)` | :arrow_up: |
| [...e/CreateDatabaseDiscoveryRuleStatementUpdater.java](https://codecov.io/gh/apache/shardingsphere/pull/21753/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvZGItZGlzY292ZXJ5L2Rpc3RzcWwvaGFuZGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGJkaXNjb3ZlcnkvZGlzdHNxbC9oYW5kbGVyL3VwZGF0ZS9DcmVhdGVEYXRhYmFzZURpc2NvdmVyeVJ1bGVTdGF0ZW1lbnRVcGRhdGVyLmphdmE=) | `74.28% <ø> (-4.29%)` | :arrow_down: |
| [...core/DatabaseDiscoveryDistSQLStatementVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/21753/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvZGItZGlzY292ZXJ5L2Rpc3RzcWwvcGFyc2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kYmRpc2NvdmVyeS9kaXN0c3FsL3BhcnNlci9jb3JlL0RhdGFiYXNlRGlzY292ZXJ5RGlzdFNRTFN0YXRlbWVudFZpc2l0b3IuamF2YQ==) | `50.00% <ø> (ø)` | |
| [...esher/type/AlterTableStatementSchemaRefresher.java](https://codecov.io/gh/apache/shardingsphere/pull/21753/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5mcmEvY29udGV4dC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvaW5mcmEvY29udGV4dC9yZWZyZXNoZXIvdHlwZS9BbHRlclRhYmxlU3RhdGVtZW50U2NoZW1hUmVmcmVzaGVyLmphdmE=) | `7.40% <0.00%> (ø)` | |
| [...resher/type/AlterViewStatementSchemaRefresher.java](https://codecov.io/gh/apache/shardingsphere/pull/21753/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5mcmEvY29udGV4dC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvaW5mcmEvY29udGV4dC9yZWZyZXNoZXIvdHlwZS9BbHRlclZpZXdTdGF0ZW1lbnRTY2hlbWFSZWZyZXNoZXIuamF2YQ==) | `5.71% <0.00%> (ø)` | |
| [...sher/type/CreateTableStatementSchemaRefresher.java](https://codecov.io/gh/apache/shardingsphere/pull/21753/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5mcmEvY29udGV4dC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvaW5mcmEvY29udGV4dC9yZWZyZXNoZXIvdHlwZS9DcmVhdGVUYWJsZVN0YXRlbWVudFNjaGVtYVJlZnJlc2hlci5qYXZh) | `11.76% <0.00%> (ø)` | |
| [...esher/type/CreateViewStatementSchemaRefresher.java](https://codecov.io/gh/apache/shardingsphere/pull/21753/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5mcmEvY29udGV4dC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvaW5mcmEvY29udGV4dC9yZWZyZXNoZXIvdHlwZS9DcmVhdGVWaWV3U3RhdGVtZW50U2NoZW1hUmVmcmVzaGVyLmphdmE=) | `10.00% <0.00%> (ø)` | |
| [...rdingsphere/infra/util/reflect/ReflectiveUtil.java](https://codecov.io/gh/apache/shardingsphere/pull/21753/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5mcmEvdXRpbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvaW5mcmEvdXRpbC9yZWZsZWN0L1JlZmxlY3RpdmVVdGlsLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../proxy/backend/communication/ProxySQLExecutor.java](https://codecov.io/gh/apache/shardingsphere/pull/21753/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9jb21tdW5pY2F0aW9uL1Byb3h5U1FMRXhlY3V0b3IuamF2YQ==) | `34.32% <0.00%> (ø)` | |
| ... and [172 more](https://codecov.io/gh/apache/shardingsphere/pull/21753/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] sandynz commented on pull request #21753: fix issue: add MySQL data type, linestring.
Posted by GitBox <gi...@apache.org>.
sandynz commented on PR #21753:
URL: https://github.com/apache/shardingsphere/pull/21753#issuecomment-1291920402
Hi @pandaapo , could you supply: 1) related MySQL document link, 2) local test table structure and result
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org