You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Anand Mazumdar <an...@apache.org> on 2017/09/21 20:26:48 UTC
Review Request 62475: Added `MARK_AGENT_GONE` call to the v1 Master
API.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62475/
-----------------------------------------------------------
Review request for mesos and Vinod Kone.
Bugs: MESOS-7443
https://issues.apache.org/jira/browse/MESOS-7443
Repository: mesos
Description
-------
This change introduces the `MARK_AGENT_GONE` call that can be
used by operators to assert that a given agent has failed. It
is specially useful for stateful frameworks to ascertain whether
its safe to move the workload to a new agent.
Diffs
-----
include/mesos/master/master.proto b94e90287982e620749c10bec77cf0af10318415
include/mesos/v1/master/master.proto 7499fa4f62ab18dd3cd4827461717bc9c688dc49
Diff: https://reviews.apache.org/r/62475/diff/1/
Testing
-------
make check
Thanks,
Anand Mazumdar
Re: Review Request 62475: Added `MARK_AGENT_GONE` call to the v1
Master API.
Posted by Anand Mazumdar <an...@apache.org>.
> On Sept. 25, 2017, 11:41 p.m., Vinod Kone wrote:
> > include/mesos/master/master.proto
> > Lines 205-206 (patched)
> > <https://reviews.apache.org/r/62475/diff/4/?file=1833352#file1833352line205>
> >
> > The last sentence is not strictly true right? A new agent with a new id but old volumes/reservations can still come back right? If so, we should mention that possibility.
hmm, thats possible. The reason I did not mention it was that it's not possible without the operator manually tinkering and removing the `latest` symlink. What do you think?
- Anand
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62475/#review186171
-----------------------------------------------------------
On Sept. 24, 2017, 5:06 p.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62475/
> -----------------------------------------------------------
>
> (Updated Sept. 24, 2017, 5:06 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-7443
> https://issues.apache.org/jira/browse/MESOS-7443
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This change introduces the `MARK_AGENT_GONE` call that can be
> used by operators to assert that a given agent has failed. It
> is specially useful for stateful frameworks to ascertain whether
> its safe to move the workload to a new agent.
>
>
> Diffs
> -----
>
> include/mesos/master/master.proto b94e90287982e620749c10bec77cf0af10318415
> include/mesos/v1/master/master.proto 7499fa4f62ab18dd3cd4827461717bc9c688dc49
>
>
> Diff: https://reviews.apache.org/r/62475/diff/4/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 62475: Added `MARK_AGENT_GONE` call to the v1
Master API.
Posted by Vinod Kone <vi...@gmail.com>.
> On Sept. 25, 2017, 11:41 p.m., Vinod Kone wrote:
> > include/mesos/master/master.proto
> > Lines 205-206 (patched)
> > <https://reviews.apache.org/r/62475/diff/4/?file=1833352#file1833352line205>
> >
> > The last sentence is not strictly true right? A new agent with a new id but old volumes/reservations can still come back right? If so, we should mention that possibility.
>
> Anand Mazumdar wrote:
> hmm, thats possible. The reason I did not mention it was that it's not possible without the operator manually tinkering and removing the `latest` symlink. What do you think?
I see. ok.
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62475/#review186171
-----------------------------------------------------------
On Sept. 24, 2017, 5:06 p.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62475/
> -----------------------------------------------------------
>
> (Updated Sept. 24, 2017, 5:06 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-7443
> https://issues.apache.org/jira/browse/MESOS-7443
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This change introduces the `MARK_AGENT_GONE` call that can be
> used by operators to assert that a given agent has failed. It
> is specially useful for stateful frameworks to ascertain whether
> its safe to move the workload to a new agent.
>
>
> Diffs
> -----
>
> include/mesos/master/master.proto b94e90287982e620749c10bec77cf0af10318415
> include/mesos/v1/master/master.proto 7499fa4f62ab18dd3cd4827461717bc9c688dc49
>
>
> Diff: https://reviews.apache.org/r/62475/diff/4/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 62475: Added `MARK_AGENT_GONE` call to the v1
Master API.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62475/#review186171
-----------------------------------------------------------
Fix it, then Ship it!
include/mesos/master/master.proto
Lines 205-206 (patched)
<https://reviews.apache.org/r/62475/#comment262623>
The last sentence is not strictly true right? A new agent with a new id but old volumes/reservations can still come back right? If so, we should mention that possibility.
- Vinod Kone
On Sept. 24, 2017, 5:06 p.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62475/
> -----------------------------------------------------------
>
> (Updated Sept. 24, 2017, 5:06 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-7443
> https://issues.apache.org/jira/browse/MESOS-7443
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This change introduces the `MARK_AGENT_GONE` call that can be
> used by operators to assert that a given agent has failed. It
> is specially useful for stateful frameworks to ascertain whether
> its safe to move the workload to a new agent.
>
>
> Diffs
> -----
>
> include/mesos/master/master.proto b94e90287982e620749c10bec77cf0af10318415
> include/mesos/v1/master/master.proto 7499fa4f62ab18dd3cd4827461717bc9c688dc49
>
>
> Diff: https://reviews.apache.org/r/62475/diff/4/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 62475: Added `MARK_AGENT_GONE` call to the v1
Master API.
Posted by Anand Mazumdar <an...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62475/
-----------------------------------------------------------
(Updated Sept. 24, 2017, 5:06 p.m.)
Review request for mesos and Vinod Kone.
Changes
-------
Review comments
Bugs: MESOS-7443
https://issues.apache.org/jira/browse/MESOS-7443
Repository: mesos
Description (updated)
-------
This change introduces the `MARK_AGENT_GONE` call that can be
used by operators to assert that a given agent has failed. It
is specially useful for stateful frameworks to ascertain whether
its safe to move the workload to a new agent.
Diffs (updated)
-----
include/mesos/master/master.proto b94e90287982e620749c10bec77cf0af10318415
include/mesos/v1/master/master.proto 7499fa4f62ab18dd3cd4827461717bc9c688dc49
Diff: https://reviews.apache.org/r/62475/diff/4/
Changes: https://reviews.apache.org/r/62475/diff/3-4/
Testing
-------
make check
Thanks,
Anand Mazumdar
Re: Review Request 62475: Added `MARK_AGENT_GONE` call to the v1
Master API.
Posted by Anand Mazumdar <an...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62475/#review186012
-----------------------------------------------------------
include/mesos/master/master.proto
Lines 202 (patched)
<https://reviews.apache.org/r/62475/#comment262371>
s/failed/failed and it is never coming back
Add a line that reservations/volumes would no longer be accessible. Add an example around a auto scaling group or a cloud instance.
include/mesos/master/master.proto
Lines 207 (patched)
<https://reviews.apache.org/r/62475/#comment262374>
Also add that the agent would be shut down in this case when it tries to reregister when the partition heals.
include/mesos/master/master.proto
Lines 209 (patched)
<https://reviews.apache.org/r/62475/#comment262370>
Consider making it `repeated`.
- Anand Mazumdar
On Sept. 21, 2017, 9:38 p.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62475/
> -----------------------------------------------------------
>
> (Updated Sept. 21, 2017, 9:38 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-7443
> https://issues.apache.org/jira/browse/MESOS-7443
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This change introduces the `MARK_AGENT_GONE` call that can be
> used by operators to assert that a given agent has failed. It
> is specially useful for stateful frameworks to ascertain whether
> its safe to move the workload to a new agent.
>
> Review: https://reviews.apache.org/r/62475
>
>
> Diffs
> -----
>
> include/mesos/master/master.proto b94e90287982e620749c10bec77cf0af10318415
> include/mesos/v1/master/master.proto 7499fa4f62ab18dd3cd4827461717bc9c688dc49
>
>
> Diff: https://reviews.apache.org/r/62475/diff/3/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 62475: Added `MARK_AGENT_GONE` call to the v1
Master API.
Posted by Anand Mazumdar <an...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62475/
-----------------------------------------------------------
(Updated Sept. 21, 2017, 9:38 p.m.)
Review request for mesos and Vinod Kone.
Bugs: MESOS-7443
https://issues.apache.org/jira/browse/MESOS-7443
Repository: mesos
Description
-------
This change introduces the `MARK_AGENT_GONE` call that can be
used by operators to assert that a given agent has failed. It
is specially useful for stateful frameworks to ascertain whether
its safe to move the workload to a new agent.
Review: https://reviews.apache.org/r/62475
Diffs (updated)
-----
include/mesos/master/master.proto b94e90287982e620749c10bec77cf0af10318415
include/mesos/v1/master/master.proto 7499fa4f62ab18dd3cd4827461717bc9c688dc49
Diff: https://reviews.apache.org/r/62475/diff/3/
Changes: https://reviews.apache.org/r/62475/diff/2-3/
Testing
-------
make check
Thanks,
Anand Mazumdar
Re: Review Request 62475: Added `MARK_AGENT_GONE` call to the v1
Master API.
Posted by Anand Mazumdar <an...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62475/
-----------------------------------------------------------
(Updated Sept. 21, 2017, 9:35 p.m.)
Review request for mesos and Vinod Kone.
Bugs: MESOS-7443
https://issues.apache.org/jira/browse/MESOS-7443
Repository: mesos
Description (updated)
-------
This change introduces the `MARK_AGENT_GONE` call that can be
used by operators to assert that a given agent has failed. It
is specially useful for stateful frameworks to ascertain whether
its safe to move the workload to a new agent.
Review: https://reviews.apache.org/r/62475
Diffs (updated)
-----
include/mesos/master/master.proto b94e90287982e620749c10bec77cf0af10318415
include/mesos/v1/master/master.proto 7499fa4f62ab18dd3cd4827461717bc9c688dc49
Diff: https://reviews.apache.org/r/62475/diff/2/
Changes: https://reviews.apache.org/r/62475/diff/1-2/
Testing
-------
make check
Thanks,
Anand Mazumdar