You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by gi...@git.apache.org on 2017/06/27 18:42:25 UTC

[GitHub] rabbah commented on a change in pull request #2215: Updates for Max Activation List Limit

rabbah commented on a change in pull request #2215: Updates for Max Activation List Limit
URL: https://github.com/apache/incubator-openwhisk/pull/2215#discussion_r124360654
 
 

 ##########
 File path: tools/cli/go-whisk-cli/commands/activation.go
 ##########
 @@ -31,12 +31,9 @@ import (
     "github.com/spf13/cobra"
 )
 
-const (
-    PollInterval = time.Second * 2
-    Delay        = time.Second * 5
-)
+const MAX_ACTIVATION_LIMIT = 200
 
 Review comment:
   do you intend to keep these limits in the cli if the change is in the backend?
   that is, will you hardcode the 200 in this pr or defer this change to a time when you can get the limit from the api info?
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services