You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commons-dev@ws.apache.org by "Jarek Gawor (JIRA)" <ji...@apache.org> on 2008/12/02 22:36:44 UTC

[jira] Created: (WSCOMMONS-405) Transport: In some cases HTTP GET on services is not handled correctly in HTTPWorker.java

Transport: In some cases HTTP GET on services is not handled correctly in HTTPWorker.java
-----------------------------------------------------------------------------------------

                 Key: WSCOMMONS-405
                 URL: https://issues.apache.org/jira/browse/WSCOMMONS-405
             Project: WS-Commons
          Issue Type: Bug
            Reporter: Jarek Gawor


In some cases HTTP GET on services is not handled correctly in HTTPWorker. Instead of calling the service code a list of deployed services is returned instead. That happens if the request uri does not have "?" in it. 

One quick solution for this problem is to remove the following code block from HTTPWorker.java:

Index: modules/http/src/org/apache/axis2/transport/http/HTTPWorker.java
===================================================================
--- modules/http/src/org/apache/axis2/transport/http/HTTPWorker.java	(revision 722613)
+++ modules/http/src/org/apache/axis2/transport/http/HTTPWorker.java	(working copy)
@@ -111,17 +111,6 @@
                                 }
                             }
                         }
-                    } else {
-                        String serviceName = uri.replaceAll(contextPath, "");
-                        if (serviceName.indexOf("/") < 0) {
-                            String s = HTTPTransportReceiver
-                                    .printServiceHTML(serviceName, configurationContext);
-                            response.setStatus(HttpStatus.SC_OK);
-                            response.setContentType("text/html");
-                            OutputStream out = response.getOutputStream();
-                            out.write(EncodingUtils.getBytes(s, HTTP.ISO_8859_1));
-                            return;
-                        }
                     }
                 }
             }


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WSCOMMONS-405) Transport: In some cases HTTP GET on services is not handled correctly in HTTPWorker.java

Posted by "Andreas Veithen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WSCOMMONS-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12652587#action_12652587 ] 

Andreas Veithen commented on WSCOMMONS-405:
-------------------------------------------

This means that the information produced by HTTPTransportReceiver.printServiceHTML is no longer accessible. Is that really what we want?

> Transport: In some cases HTTP GET on services is not handled correctly in HTTPWorker.java
> -----------------------------------------------------------------------------------------
>
>                 Key: WSCOMMONS-405
>                 URL: https://issues.apache.org/jira/browse/WSCOMMONS-405
>             Project: WS-Commons
>          Issue Type: Bug
>            Reporter: Jarek Gawor
>            Assignee: Jarek Gawor
>         Attachments: WSCOMMONS-405.patch
>
>
> In some cases HTTP GET on services is not handled correctly in HTTPWorker. Instead of calling the service code a list of deployed services is returned instead. That happens if the request uri does not have "?" in it. 
> One quick solution for this problem is to remove the following code block from HTTPWorker.java:
> Index: modules/http/src/org/apache/axis2/transport/http/HTTPWorker.java
> ===================================================================
> --- modules/http/src/org/apache/axis2/transport/http/HTTPWorker.java	(revision 722613)
> +++ modules/http/src/org/apache/axis2/transport/http/HTTPWorker.java	(working copy)
> @@ -111,17 +111,6 @@
>                                  }
>                              }
>                          }
> -                    } else {
> -                        String serviceName = uri.replaceAll(contextPath, "");
> -                        if (serviceName.indexOf("/") < 0) {
> -                            String s = HTTPTransportReceiver
> -                                    .printServiceHTML(serviceName, configurationContext);
> -                            response.setStatus(HttpStatus.SC_OK);
> -                            response.setContentType("text/html");
> -                            OutputStream out = response.getOutputStream();
> -                            out.write(EncodingUtils.getBytes(s, HTTP.ISO_8859_1));
> -                            return;
> -                        }
>                      }
>                  }
>              }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WSCOMMONS-405) Transport: In some cases HTTP GET on services is not handled correctly in HTTPWorker.java

Posted by "Jarek Gawor (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WSCOMMONS-405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jarek Gawor updated WSCOMMONS-405:
----------------------------------

    Attachment: WSCOMMONS-405.patch

> Transport: In some cases HTTP GET on services is not handled correctly in HTTPWorker.java
> -----------------------------------------------------------------------------------------
>
>                 Key: WSCOMMONS-405
>                 URL: https://issues.apache.org/jira/browse/WSCOMMONS-405
>             Project: WS-Commons
>          Issue Type: Bug
>            Reporter: Jarek Gawor
>         Attachments: WSCOMMONS-405.patch
>
>
> In some cases HTTP GET on services is not handled correctly in HTTPWorker. Instead of calling the service code a list of deployed services is returned instead. That happens if the request uri does not have "?" in it. 
> One quick solution for this problem is to remove the following code block from HTTPWorker.java:
> Index: modules/http/src/org/apache/axis2/transport/http/HTTPWorker.java
> ===================================================================
> --- modules/http/src/org/apache/axis2/transport/http/HTTPWorker.java	(revision 722613)
> +++ modules/http/src/org/apache/axis2/transport/http/HTTPWorker.java	(working copy)
> @@ -111,17 +111,6 @@
>                                  }
>                              }
>                          }
> -                    } else {
> -                        String serviceName = uri.replaceAll(contextPath, "");
> -                        if (serviceName.indexOf("/") < 0) {
> -                            String s = HTTPTransportReceiver
> -                                    .printServiceHTML(serviceName, configurationContext);
> -                            response.setStatus(HttpStatus.SC_OK);
> -                            response.setContentType("text/html");
> -                            OutputStream out = response.getOutputStream();
> -                            out.write(EncodingUtils.getBytes(s, HTTP.ISO_8859_1));
> -                            return;
> -                        }
>                      }
>                  }
>              }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (WSCOMMONS-405) Transport: In some cases HTTP GET on services is not handled correctly in HTTPWorker.java

Posted by "Jarek Gawor (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WSCOMMONS-405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jarek Gawor resolved WSCOMMONS-405.
-----------------------------------

    Resolution: Fixed
      Assignee: Jarek Gawor

Committed the patch to trunk (revision 722634).


> Transport: In some cases HTTP GET on services is not handled correctly in HTTPWorker.java
> -----------------------------------------------------------------------------------------
>
>                 Key: WSCOMMONS-405
>                 URL: https://issues.apache.org/jira/browse/WSCOMMONS-405
>             Project: WS-Commons
>          Issue Type: Bug
>            Reporter: Jarek Gawor
>            Assignee: Jarek Gawor
>         Attachments: WSCOMMONS-405.patch
>
>
> In some cases HTTP GET on services is not handled correctly in HTTPWorker. Instead of calling the service code a list of deployed services is returned instead. That happens if the request uri does not have "?" in it. 
> One quick solution for this problem is to remove the following code block from HTTPWorker.java:
> Index: modules/http/src/org/apache/axis2/transport/http/HTTPWorker.java
> ===================================================================
> --- modules/http/src/org/apache/axis2/transport/http/HTTPWorker.java	(revision 722613)
> +++ modules/http/src/org/apache/axis2/transport/http/HTTPWorker.java	(working copy)
> @@ -111,17 +111,6 @@
>                                  }
>                              }
>                          }
> -                    } else {
> -                        String serviceName = uri.replaceAll(contextPath, "");
> -                        if (serviceName.indexOf("/") < 0) {
> -                            String s = HTTPTransportReceiver
> -                                    .printServiceHTML(serviceName, configurationContext);
> -                            response.setStatus(HttpStatus.SC_OK);
> -                            response.setContentType("text/html");
> -                            OutputStream out = response.getOutputStream();
> -                            out.write(EncodingUtils.getBytes(s, HTTP.ISO_8859_1));
> -                            return;
> -                        }
>                      }
>                  }
>              }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WSCOMMONS-405) Transport: In some cases HTTP GET on services is not handled correctly in HTTPWorker.java

Posted by "Jarek Gawor (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WSCOMMONS-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12652620#action_12652620 ] 

Jarek Gawor commented on WSCOMMONS-405:
---------------------------------------

I'm pretty sure that the same info can be obtained by accessing the /axis2/services context.




> Transport: In some cases HTTP GET on services is not handled correctly in HTTPWorker.java
> -----------------------------------------------------------------------------------------
>
>                 Key: WSCOMMONS-405
>                 URL: https://issues.apache.org/jira/browse/WSCOMMONS-405
>             Project: WS-Commons
>          Issue Type: Bug
>            Reporter: Jarek Gawor
>            Assignee: Jarek Gawor
>         Attachments: WSCOMMONS-405.patch
>
>
> In some cases HTTP GET on services is not handled correctly in HTTPWorker. Instead of calling the service code a list of deployed services is returned instead. That happens if the request uri does not have "?" in it. 
> One quick solution for this problem is to remove the following code block from HTTPWorker.java:
> Index: modules/http/src/org/apache/axis2/transport/http/HTTPWorker.java
> ===================================================================
> --- modules/http/src/org/apache/axis2/transport/http/HTTPWorker.java	(revision 722613)
> +++ modules/http/src/org/apache/axis2/transport/http/HTTPWorker.java	(working copy)
> @@ -111,17 +111,6 @@
>                                  }
>                              }
>                          }
> -                    } else {
> -                        String serviceName = uri.replaceAll(contextPath, "");
> -                        if (serviceName.indexOf("/") < 0) {
> -                            String s = HTTPTransportReceiver
> -                                    .printServiceHTML(serviceName, configurationContext);
> -                            response.setStatus(HttpStatus.SC_OK);
> -                            response.setContentType("text/html");
> -                            OutputStream out = response.getOutputStream();
> -                            out.write(EncodingUtils.getBytes(s, HTTP.ISO_8859_1));
> -                            return;
> -                        }
>                      }
>                  }
>              }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.