You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Meng Zhu <mz...@mesosphere.io> on 2018/03/28 22:45:33 UTC

Review Request 66346: Added two matchers for TaskInfo and TaskGroup.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66346/
-----------------------------------------------------------

Review request for mesos and Greg Mann.


Repository: mesos


Description
-------

Added a matcher to match the taskID of `Option<TaskInfo>`.
Added a matcher to match an `Option<TaskGroupInfo>` which
contains a task with the specified taskID.


Diffs
-----

  src/tests/mesos.hpp 46c271b5c5bedbdabd58b3cdbb82216d55c846bd 


Diff: https://reviews.apache.org/r/66346/diff/1/


Testing
-------

make check


Thanks,

Meng Zhu

Re: Review Request 66346: Added three matchers for agent tests.

Posted by Meng Zhu <mz...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66346/
-----------------------------------------------------------

(Updated April 3, 2018, 8:21 p.m.)


Review request for mesos and Greg Mann.


Changes
-------

Added one more matcher `AuthorizationRequestHasTaskID`. Addressed comments.


Summary (updated)
-----------------

Added three matchers for agent tests.


Repository: mesos


Description (updated)
-------

Added a matcher to match the `TaskID` of `Option<TaskInfo>`.
Added a matcher to match an `Option<TaskGroupInfo>` which
contains a task with the specified `TaskID`.
Added a matcher to match the `TaskID` of
`authorization::Request.Object.TaskInfo`.


Diffs (updated)
-----

  src/tests/mesos.hpp 46c271b5c5bedbdabd58b3cdbb82216d55c846bd 


Diff: https://reviews.apache.org/r/66346/diff/2/

Changes: https://reviews.apache.org/r/66346/diff/1-2/


Testing
-------

make check


Thanks,

Meng Zhu

Re: Review Request 66346: Added two matchers for TaskInfo and TaskGroup.

Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66346/#review200403
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/mesos.hpp
Lines 3604 (patched)
<https://reviews.apache.org/r/66346/#comment281166>

    s/taskID/task ID/



src/tests/mesos.hpp
Lines 3605 (patched)
<https://reviews.apache.org/r/66346/#comment281164>

    s/taskID/taskId/
    
    here and below.
    
    Also, I like your use of "Has" in the name below; let's do
    s/OptionTaskEqTaskID/OptionTaskHasTaskID/



src/tests/mesos.hpp
Lines 3612 (patched)
<https://reviews.apache.org/r/66346/#comment281162>

    s/taskID/task ID/



src/tests/mesos.hpp
Lines 3619 (patched)
<https://reviews.apache.org/r/66346/#comment281165>

    I don't think you need the underscore here? Just `taskInfo` should be OK.


- Greg Mann


On March 28, 2018, 10:45 p.m., Meng Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66346/
> -----------------------------------------------------------
> 
> (Updated March 28, 2018, 10:45 p.m.)
> 
> 
> Review request for mesos and Greg Mann.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a matcher to match the taskID of `Option<TaskInfo>`.
> Added a matcher to match an `Option<TaskGroupInfo>` which
> contains a task with the specified taskID.
> 
> 
> Diffs
> -----
> 
>   src/tests/mesos.hpp 46c271b5c5bedbdabd58b3cdbb82216d55c846bd 
> 
> 
> Diff: https://reviews.apache.org/r/66346/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>