You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@geode.apache.org by "Petahhh (GitHub)" <gi...@apache.org> on 2018/12/13 18:01:09 UTC

[GitHub] [geode] Petahhh commented on pull request #2998: GEODE-6103 RegionCreateFunction takes RegionConfig in argument

The name `checkIfRegionAlreadyExists` can be better. My understanding of the current behaviour is:

If the region doesn't exist, do not throw an error

If the region exists and there is conflict in the configuration, throw an error.

I'm not sure what a better name would be. Perhaps you could introduce a new method that checks for the region's existence and return a boolean? Then the current function could be renamed `checkForRegionConfigurationConflicts`?

[ Full content available at: https://github.com/apache/geode/pull/2998 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org