You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "lupyuen (via GitHub)" <gi...@apache.org> on 2024/10/27 05:49:24 UTC

[PR] CI: Check out the correct branch of nuttx repo when compiling nuttx-apps [nuttx-apps]

lupyuen opened a new pull request, #2780:
URL: https://github.com/apache/nuttx-apps/pull/2780

   ## Summary
   
   When compiling the Release Branch of `nuttx-apps`, our CI Workflow `build.yml` checks out the Master Branch of `nuttx` repo, which is incorrect. This happens due to a typo in `build.yml`: https://github.com/apache/nuttx/issues/14513
   
   This PR fixes the typo in `build.yml` to checkout the correct branch of `nuttx` repo.
   
   ## Impact
   
   When compiling the Release Branch of `nuttx-apps`, our CI Workflow `build.yml` now checks out the Release Branch of `nuttx` repo.
   
   No changes when compiling the Master Branch of `nuttx` and `nuttx-apps` repos.
   
   ## Testing
   
   __Before the PR:__ Fetch-Source Log shows that CI is incorrectly checking out the Master Branch of `nuttx` repo (instead of `releases/12.7`): https://github.com/apache/nuttx-apps/actions/runs/11518661640/job/32069568370#step:3:66
   ```text
   /usr/bin/git checkout --progress --force -B master refs/remotes/origin/master
   ```
   
   __After the PR:__ When we [change `name` to `os_ref`](https://github.com/lupyuen5/label-nuttx-apps/commit/cc44bf95320db2d53238097197b03c6f3485b338), CI correctly checks out the Release Branch of `nuttx` repo: https://github.com/lupyuen5/label-nuttx-apps/actions/runs/11528123257/job/32094821811#step:3:57
   ```text
   /usr/bin/git checkout --progress --force -B releases/12.7 refs/remotes/origin/releases/12.7
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] CI: Check out the correct branch of nuttx repo when compiling nuttx-apps [nuttx-apps]

Posted by "lupyuen (via GitHub)" <gi...@apache.org>.
lupyuen commented on PR #2780:
URL: https://github.com/apache/nuttx-apps/pull/2780#issuecomment-2440220406

   Thanks @cederom! I'll wait till Oct 30, don't want to mess up our perfect GitHub Runners now :-)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] CI: Check out the correct branch of nuttx repo when compiling nuttx-apps [nuttx-apps]

Posted by "cederom (via GitHub)" <gi...@apache.org>.
cederom commented on PR #2780:
URL: https://github.com/apache/nuttx-apps/pull/2780#issuecomment-2453017200

   i have restarted the CI for verification :-) 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] CI: Check out the correct branch of nuttx repo when compiling nuttx-apps [nuttx-apps]

Posted by "lupyuen (via GitHub)" <gi...@apache.org>.
lupyuen commented on PR #2780:
URL: https://github.com/apache/nuttx-apps/pull/2780#issuecomment-2453018053

   @cederom Thanks! Let's wait for the broken builds to clear, so we won't pile on more problems :-)
   - https://github.com/apache/nuttx/issues/14598#issuecomment-2452771959


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] CI: Check out the correct branch of nuttx repo when compiling nuttx-apps [nuttx-apps]

Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #2780:
URL: https://github.com/apache/nuttx-apps/pull/2780


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org