You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/11/12 21:23:15 UTC

[GitHub] [airflow] peloyeje opened a new issue #18632: Auto-refresh doesn't take into account the selected date

peloyeje opened a new issue #18632:
URL: https://github.com/apache/airflow/issues/18632


   ### Apache Airflow version
   
   2.1.3
   
   ### Operating System
   
   Debian GNU/Linux 9 (stretch)
   
   ### Versions of Apache Airflow Providers
   
   _No response_
   
   ### Deployment
   
   Other Docker-based deployment
   
   ### Deployment details
   
   _No response_
   
   ### What happened
   
   In the DAG tree view, if I select a custom date in the date filter (top left corner) and press "update", DAG runs are correctly filtered to the selected date and number of runs.
    
   However, if the "auto-refresh" toggle is on, when the next tick refresh happens, the date filter is no longer taken into account and the UI displays the actual **latest** x DAG runs status. However, neither the header dates (45° angle) nor the date filter reflect this new time window 
   
   I investigated in the network inspector and it seems that the xhr request that fetches dag runs status doesn't contain a date parameter and thus always fetch the latest DAG run data
   
   ### What you expected to happen
   
   I expect that the auto-refresh feature preserves the selected time window
   
   ### How to reproduce
   
   Open a DAG with at least 20 dag runs
   Make sure autorefresh is disabled
   Select a filter date earlier than the 10th dag run start date and a "number of runs" value of 10, press "update"
   The DAG tree view should now be focused on the 10 first dag runs
   Now toggle autorefresh and wait for next tick
   The DAG tree view will now display status of the latest 10 runs but the header dates will still reflect the old start dates
   
   ### Anything else
   
   _No response_
   
   ### Are you willing to submit PR?
   
   - [X] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://github.com/apache/airflow/blob/main/CODE_OF_CONDUCT.md)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] boring-cyborg[bot] commented on issue #18632: Auto-refresh doesn't take into account the selected date

Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on issue #18632:
URL: https://github.com/apache/airflow/issues/18632#issuecomment-931154518


   Thanks for opening your first issue here! Be sure to follow the issue template!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] bbovenzi closed issue #18632: Auto-refresh doesn't take into account the selected date

Posted by GitBox <gi...@apache.org>.
bbovenzi closed issue #18632:
URL: https://github.com/apache/airflow/issues/18632


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] peloyeje closed issue #18632: Auto-refresh doesn't take into account the selected date

Posted by GitBox <gi...@apache.org>.
peloyeje closed issue #18632:
URL: https://github.com/apache/airflow/issues/18632


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] peloyeje commented on issue #18632: Auto-refresh doesn't take into account the selected date

Posted by GitBox <gi...@apache.org>.
peloyeje commented on issue #18632:
URL: https://github.com/apache/airflow/issues/18632#issuecomment-933238475


   Yep exactly, I looked around and I was planning on adding the base date as a meta tag in the html template in order to match the current implementation. If that's fine by you I'll submit a PR in the next couple of days :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] bbovenzi commented on issue #18632: Auto-refresh doesn't take into account the selected date

Posted by GitBox <gi...@apache.org>.
bbovenzi commented on issue #18632:
URL: https://github.com/apache/airflow/issues/18632#issuecomment-933225868


   Makes sense to me. It should be relatively easily to just pass the dat in `tree.js` [here](https://github.com/apache/airflow/blob/main/airflow/www/static/js/tree.js#L433). I believe the webserver code is already built to handle the `base_date`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] bbovenzi commented on issue #18632: Auto-refresh doesn't take into account the selected date

Posted by GitBox <gi...@apache.org>.
bbovenzi commented on issue #18632:
URL: https://github.com/apache/airflow/issues/18632#issuecomment-967548594


   @peloyeje do you still want to take this on or should I finish this out? Quite a bit changed with #18675


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] bbovenzi edited a comment on issue #18632: Auto-refresh doesn't take into account the selected date

Posted by GitBox <gi...@apache.org>.
bbovenzi edited a comment on issue #18632:
URL: https://github.com/apache/airflow/issues/18632#issuecomment-933225868


   Makes sense to me. It should be relatively easily to just pass the date in `tree.js` [here](https://github.com/apache/airflow/blob/main/airflow/www/static/js/tree.js#L433). I believe the webserver code is already built to handle the `base_date`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] sbialkowski-pixel commented on issue #18632: Auto-refresh doesn't take into account the selected date

Posted by GitBox <gi...@apache.org>.
sbialkowski-pixel commented on issue #18632:
URL: https://github.com/apache/airflow/issues/18632#issuecomment-955179789


   I will add my observation :)
   Refresh button also cause this problem.
   Raw view (without day/time filter in he left corner:
   ![Zrzut ekranu 2021-10-30 111252](https://user-images.githubusercontent.com/60385441/139527335-9b482ed4-5f0f-4761-9b49-42c058e48db5.png)
   After filter apply (button update)
   ![Zrzut ekranu 2021-10-30 111309](https://user-images.githubusercontent.com/60385441/139527337-dea3411f-1b17-44f9-9fad-f808aae46f25.png)
   After refresh button click
   ![Zrzut ekranu 2021-10-30 111329](https://user-images.githubusercontent.com/60385441/139527334-887429ef-5310-4bf8-af1f-0cb6c0b18594.png)
   
   Legend respects day/time filter but taskInstances not :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] peloyeje commented on issue #18632: Auto-refresh doesn't take into account the selected date

Posted by GitBox <gi...@apache.org>.
peloyeje commented on issue #18632:
URL: https://github.com/apache/airflow/issues/18632#issuecomment-968740933


   @bbovenzi sorry for my late reply, yes please go ahead, you're right it may be easier if you handle this :)
   Great job on https://github.com/apache/airflow/pull/18675 btw !


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org