You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2019/06/06 14:27:16 UTC

[GitHub] [calcite] XuMingmin commented on issue #1253: [CALCITE-3073] Support read from special timestamp in KafkaAdapter

XuMingmin commented on issue #1253: [CALCITE-3073] Support read from special timestamp in KafkaAdapter
URL: https://github.com/apache/calcite/pull/1253#issuecomment-499517717
 
 
   @wangzzu thanks to prepare it quickly, the implementation is a bit different from my thought.
   
   FYI my idea, `KAFKA_TIMESTAMP` is a reserved keyword in KafkaAdapter, given a query like `SELECT * FROM KAFKA_TABLE WHERE KAFKA_TIMESTAMP > CURRENT_TIMESTAMP-1`, KafkaAdapter would take the filter clause `KAFKA_TIMESTAMP > CURRENT_TIMESTAMP-1` directly.
   
   In this way, users do not change table definition again and again, the only question is, is it good to have the reserved keyword, and how. (for HOW, we may have the column by default in `KafkaRowConverter`) 
   
   @danny0405 @asereda-gs any comments?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services