You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by vm...@apache.org on 2003/11/29 18:22:06 UTC

cvs commit: maven-plugins/junit-report project.xml plugin.jelly

vmassol     2003/11/29 09:22:06

  Modified:    junit-report/xdocs changes.xml
               junit-report project.xml plugin.jelly
  Log:
  Deprecated goal <code>maven-junit-report-plugin:report</code>. It is replaced by <code>junit-report:report</code>.
  
  Revision  Changes    Path
  1.5       +7 -0      maven-plugins/junit-report/xdocs/changes.xml
  
  Index: changes.xml
  ===================================================================
  RCS file: /home/cvs/maven-plugins/junit-report/xdocs/changes.xml,v
  retrieving revision 1.4
  retrieving revision 1.5
  diff -u -r1.4 -r1.5
  --- changes.xml	29 Sep 2003 06:18:40 -0000	1.4
  +++ changes.xml	29 Nov 2003 17:22:06 -0000	1.5
  @@ -8,6 +8,13 @@
   
     <body>
   
  +    <release version="1.4" date="in CVS">
  +      <action dev="vmassol" type="update">
  +        Deprecated goal <code>maven-junit-report-plugin:report</code>. It is
  +        replaced by <code>junit-report:report</code>.
  +      </action>
  +    </release>
  +    
       <release version="1.3" date="2003-09-29">
         <action dev="evenisse" type="fix" due-to="Kuisong Tong">
           Fixed MAVEN-452. Patch for charter encoding.
  
  
  
  1.20      +1 -8      maven-plugins/junit-report/project.xml
  
  Index: project.xml
  ===================================================================
  RCS file: /home/cvs/maven-plugins/junit-report/project.xml,v
  retrieving revision 1.19
  retrieving revision 1.20
  diff -u -r1.19 -r1.20
  --- project.xml	29 Sep 2003 05:19:12 -0000	1.19
  +++ project.xml	29 Nov 2003 17:22:06 -0000	1.20
  @@ -5,7 +5,7 @@
     <pomVersion>3</pomVersion>
     <id>maven-junit-report-plugin</id>
     <name>Maven JUnit Report Plug-in</name>
  -  <currentVersion>1.3</currentVersion>
  +  <currentVersion>1.4-SNAPSHOT</currentVersion>
     <description/>
     <shortDescription>Reports from JUnit tests</shortDescription>
     <url>http://maven.apache.org/reference/plugins/junit-report/</url>
  @@ -14,13 +14,6 @@
       <connection>scm:cvs:pserver:anoncvs@cvs.apache.org:/home/cvspublic:maven/src/plugins-build/junit-report/</connection>
       <url>http://cvs.apache.org/viewcvs/maven/src/plugins-build/junit-report/</url>
     </repository>
  -  <versions>
  -    <version>
  -      <id>1.3</id>
  -      <name>1.3</name>
  -      <tag>HEAD</tag>
  -    </version>
  -  </versions>
     <developers>
       <developer>
         <name>Vincent Massol</name>
  
  
  
  1.10      +10 -3     maven-plugins/junit-report/plugin.jelly
  
  Index: plugin.jelly
  ===================================================================
  RCS file: /home/cvs/maven-plugins/junit-report/plugin.jelly,v
  retrieving revision 1.9
  retrieving revision 1.10
  diff -u -r1.9 -r1.10
  --- plugin.jelly	28 Oct 2003 22:22:01 -0000	1.9
  +++ plugin.jelly	29 Nov 2003 17:22:06 -0000	1.10
  @@ -10,7 +10,7 @@
       <j:if test="${unitTestSourcesPresent == 'true'}">
         <doc:registerReport 
           name="Unit Tests"
  -        pluginName="maven-junit-report-plugin"
  +        pluginName="junit-report"
           description="Report on the results of the unit tests."
           link="junit-report"/>
       </j:if>
  @@ -26,8 +26,15 @@
     <!-- C R E A T E  J U N I T  X M L  R E P O R T                         -->
     <!-- ================================================================== -->
   
  -  <goal
  -    name="maven-junit-report-plugin:report"
  +  <!-- 29/11/2003: Deprecated: needs to be removed sometime in the future -->
  +  <goal name="maven-junit-report-plugin:report" 
  +    prereqs="junit-report:report"
  +    description="Generate a report from the test results (deprecated - Please use junit-report:report instead)"
  +
  +  <goal name="junit-report:report"
  +    description="Generate a report from the test results">
  +
  +  <goal name="junit-report:report"
       description="Generate a report from the test results">
   
       <j:if test="${unitTestSourcesPresent == 'true'}">
  
  
  

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


RE: cvs commit: maven-plugins/junit-report project.xml plugin.jelly

Posted by Vincent Massol <vm...@pivolis.com>.

> -----Original Message-----
> From: Jason van Zyl [mailto:jvanzyl@maven.org]
> Sent: 29 November 2003 18:41
> To: Maven Developers List
> Subject: Re: cvs commit: maven-plugins/junit-report project.xml
> plugin.jelly
> 
> On Sat, 2003-11-29 at 12:22, vmassol@apache.org wrote:
> > vmassol     2003/11/29 09:22:06
> >
> >   Modified:    junit-report/xdocs changes.xml
> >                junit-report project.xml plugin.jelly
> >   Log:
> >   Deprecated goal <code>maven-junit-report-plugin:report</code>. It
is
> replaced by <code>junit-report:report</code>.
> 
> Has the name of the plugin actually changed? The name of the goal that
> triggers the report must stay the same as the plugin name.

hmm.. Several things:
- In all my plugins I have named the report goal with [plugin
name]:report. It works fine. As the report registration allows to
specify the goal name
- The naming scheme we currently have for any goal is [plugin
name]:[goal name] and not "maven-[plugin name]-plugin:[goal name]". Do
you mean you wish to change goal names to be "maven-[plugin
name]-plugin:[goal name]"?

Ok, for now, I'll remove the deprecation stuff for the junit-report
plugin.

> 
> I would like to keep them the same for any sort of automated tasks
that
> might arise where the plugin name is needed. I think making another
goal
> with a simpler name is fine though.

Agreed but goal names are not using this now. They are using the short
form of the plugin name.

-Vincent


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: cvs commit: maven-plugins/junit-report project.xml plugin.jelly

Posted by Jason van Zyl <jv...@maven.org>.
On Sat, 2003-11-29 at 12:22, vmassol@apache.org wrote:
> vmassol     2003/11/29 09:22:06
> 
>   Modified:    junit-report/xdocs changes.xml
>                junit-report project.xml plugin.jelly
>   Log:
>   Deprecated goal <code>maven-junit-report-plugin:report</code>. It is replaced by <code>junit-report:report</code>.

Has the name of the plugin actually changed? The name of the goal that
triggers the report must stay the same as the plugin name.
  
I would like to keep them the same for any sort of automated tasks that
might arise where the plugin name is needed. I think making another goal
with a simpler name is fine though.

> -- 
> jvz.
> 
> Jason van Zyl
> jason@zenplex.com
> http://tambora.zenplex.org
> 
> In short, man creates for himself a new religion of a rational
> and technical order to justify his work and to be justified in it.
>   
>   -- Jacques Ellul, The Technological Society


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


RE: cvs commit: maven-plugins/junit-report project.xml plugin.jelly

Posted by Vincent Massol <vm...@pivolis.com>.

> -----Original Message-----
> From: dion@multitask.com.au [mailto:dion@multitask.com.au]
> Sent: 02 December 2003 14:56
> To: Maven Developers List
> Subject: Re: cvs commit: maven-plugins/junit-report project.xml
> plugin.jelly
> 
> Are we now changing the name of all the report plugins?
> 
> If so, we should do them all together. This will directly affect what
> users enter into the <report> element in the POM.

No, it doesn't :-) It only affects the internal goal that is used by the
report registration mechanism. Check any of the plugin I have written
(dashboard for example); you'll see that the <report> name is still
maven-[plugin name]-plugin but that internally the report goal called is
[plugin name]:report.

BTW, I have reverted this change for the junit-report plugin, as Jason
asked.

-Vincent

> --
> dIon Gillard, Multitask Consulting
> Blog:      http://blogs.codehaus.org/people/dion/
> 
> 
> 
> vmassol@apache.org wrote on 30/11/2003 04:22:06 AM:
> 
> > vmassol     2003/11/29 09:22:06
> >
> >   Modified:    junit-report/xdocs changes.xml
> >                junit-report project.xml plugin.jelly
> >   Log:
> >   Deprecated goal <code>maven-junit-report-plugin:report</code>. It
is
> > replaced by <code>junit-report:report</code>.
> >
> >
> >   Revision  Changes    Path
> >   1.5       +7 -0      maven-plugins/junit-report/xdocs/changes.xml
> >
> >   Index: changes.xml
> >
===================================================================
> >   RCS file: /home/cvs/maven-plugins/junit-report/xdocs/changes.xml,v
> >   retrieving revision 1.4
> >   retrieving revision 1.5
> >   diff -u -r1.4 -r1.5
> >   --- changes.xml   29 Sep 2003 06:18:40 -0000   1.4
> >   +++ changes.xml   29 Nov 2003 17:22:06 -0000   1.5
> >   @@ -8,6 +8,13 @@
> >
> >      <body>
> >
> >   +    <release version="1.4" date="in CVS">
> >   +      <action dev="vmassol" type="update">
> >   +        Deprecated goal
> <code>maven-junit-report-plugin:report</code>. It is
> >   +        replaced by <code>junit-report:report</code>.
> >   +      </action>
> >   +    </release>
> >   +
> >        <release version="1.3" date="2003-09-29">
> >          <action dev="evenisse" type="fix" due-to="Kuisong Tong">
> >            Fixed MAVEN-452. Patch for charter encoding.
> >
> >
> >
> >   1.20      +1 -8      maven-plugins/junit-report/project.xml
> >
> >   Index: project.xml
> >
===================================================================
> >   RCS file: /home/cvs/maven-plugins/junit-report/project.xml,v
> >   retrieving revision 1.19
> >   retrieving revision 1.20
> >   diff -u -r1.19 -r1.20
> >   --- project.xml   29 Sep 2003 05:19:12 -0000   1.19
> >   +++ project.xml   29 Nov 2003 17:22:06 -0000   1.20
> >   @@ -5,7 +5,7 @@
> >      <pomVersion>3</pomVersion>
> >      <id>maven-junit-report-plugin</id>
> >      <name>Maven JUnit Report Plug-in</name>
> >   -  <currentVersion>1.3</currentVersion>
> >   +  <currentVersion>1.4-SNAPSHOT</currentVersion>
> >      <description/>
> >      <shortDescription>Reports from JUnit tests</shortDescription>
> >
<url>http://maven.apache.org/reference/plugins/junit-report/</url>
> >   @@ -14,13 +14,6 @@
> > <connection>scm:cvs:pserver:anoncvs@cvs.apache.org:/home/cvspublic:
> > maven/src/plugins-build/junit-report/</connection>
> >
> <url>http://cvs.apache.org/viewcvs/maven/src/plugins-build/junit-
> report/</url>
> >      </repository>
> >   -  <versions>
> >   -    <version>
> >   -      <id>1.3</id>
> >   -      <name>1.3</name>
> >   -      <tag>HEAD</tag>
> >   -    </version>
> >   -  </versions>
> >      <developers>
> >        <developer>
> >          <name>Vincent Massol</name>
> >
> >
> >
> >   1.10      +10 -3     maven-plugins/junit-report/plugin.jelly
> >
> >   Index: plugin.jelly
> >
===================================================================
> >   RCS file: /home/cvs/maven-plugins/junit-report/plugin.jelly,v
> >   retrieving revision 1.9
> >   retrieving revision 1.10
> >   diff -u -r1.9 -r1.10
> >   --- plugin.jelly   28 Oct 2003 22:22:01 -0000   1.9
> >   +++ plugin.jelly   29 Nov 2003 17:22:06 -0000   1.10
> >   @@ -10,7 +10,7 @@
> >        <j:if test="${unitTestSourcesPresent == 'true'}">
> >          <doc:registerReport
> >            name="Unit Tests"
> >   -        pluginName="maven-junit-report-plugin"
> >   +        pluginName="junit-report"
> >            description="Report on the results of the unit tests."
> >            link="junit-report"/>
> >        </j:if>
> >   @@ -26,8 +26,15 @@
> >      <!-- C R E A T E  J U N I T  X M L  R E P O R T     -->
> >      <!--
> ================================================================== -->
> >
> >   -  <goal
> >   -    name="maven-junit-report-plugin:report"
> >   +  <!-- 29/11/2003: Deprecated: needs to be removed sometime in
the
> future -->
> >   +  <goal name="maven-junit-report-plugin:report"
> >   +    prereqs="junit-report:report"
> >   +    description="Generate a report from the test results
(deprecated
> -
> > Please use junit-report:report instead)"
> >   +
> >   +  <goal name="junit-report:report"
> >   +    description="Generate a report from the test results">
> >   +
> >   +  <goal name="junit-report:report"
> >        description="Generate a report from the test results">
> >
> >        <j:if test="${unitTestSourcesPresent == 'true'}">
> >
> >
> >
> >
> >
---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > For additional commands, e-mail: dev-help@maven.apache.org
> >
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: cvs commit: maven-plugins/junit-report project.xml plugin.jelly

Posted by di...@multitask.com.au.
Are we now changing the name of all the report plugins?

If so, we should do them all together. This will directly affect what 
users enter into the <report> element in the POM.
--
dIon Gillard, Multitask Consulting
Blog:      http://blogs.codehaus.org/people/dion/



vmassol@apache.org wrote on 30/11/2003 04:22:06 AM:

> vmassol     2003/11/29 09:22:06
> 
>   Modified:    junit-report/xdocs changes.xml
>                junit-report project.xml plugin.jelly
>   Log:
>   Deprecated goal <code>maven-junit-report-plugin:report</code>. It is 
> replaced by <code>junit-report:report</code>.
> 
> 
>   Revision  Changes    Path
>   1.5       +7 -0      maven-plugins/junit-report/xdocs/changes.xml
> 
>   Index: changes.xml
>   ===================================================================
>   RCS file: /home/cvs/maven-plugins/junit-report/xdocs/changes.xml,v
>   retrieving revision 1.4
>   retrieving revision 1.5
>   diff -u -r1.4 -r1.5
>   --- changes.xml   29 Sep 2003 06:18:40 -0000   1.4
>   +++ changes.xml   29 Nov 2003 17:22:06 -0000   1.5
>   @@ -8,6 +8,13 @@
> 
>      <body>
> 
>   +    <release version="1.4" date="in CVS">
>   +      <action dev="vmassol" type="update">
>   +        Deprecated goal 
<code>maven-junit-report-plugin:report</code>. It is
>   +        replaced by <code>junit-report:report</code>.
>   +      </action>
>   +    </release>
>   + 
>        <release version="1.3" date="2003-09-29">
>          <action dev="evenisse" type="fix" due-to="Kuisong Tong">
>            Fixed MAVEN-452. Patch for charter encoding.
> 
> 
> 
>   1.20      +1 -8      maven-plugins/junit-report/project.xml
> 
>   Index: project.xml
>   ===================================================================
>   RCS file: /home/cvs/maven-plugins/junit-report/project.xml,v
>   retrieving revision 1.19
>   retrieving revision 1.20
>   diff -u -r1.19 -r1.20
>   --- project.xml   29 Sep 2003 05:19:12 -0000   1.19
>   +++ project.xml   29 Nov 2003 17:22:06 -0000   1.20
>   @@ -5,7 +5,7 @@
>      <pomVersion>3</pomVersion>
>      <id>maven-junit-report-plugin</id>
>      <name>Maven JUnit Report Plug-in</name>
>   -  <currentVersion>1.3</currentVersion>
>   +  <currentVersion>1.4-SNAPSHOT</currentVersion>
>      <description/>
>      <shortDescription>Reports from JUnit tests</shortDescription>
>      <url>http://maven.apache.org/reference/plugins/junit-report/</url>
>   @@ -14,13 +14,6 @@
> <connection>scm:cvs:pserver:anoncvs@cvs.apache.org:/home/cvspublic:
> maven/src/plugins-build/junit-report/</connection>
> 
<url>http://cvs.apache.org/viewcvs/maven/src/plugins-build/junit-report/</url>
>      </repository>
>   -  <versions>
>   -    <version>
>   -      <id>1.3</id>
>   -      <name>1.3</name>
>   -      <tag>HEAD</tag>
>   -    </version>
>   -  </versions>
>      <developers>
>        <developer>
>          <name>Vincent Massol</name>
> 
> 
> 
>   1.10      +10 -3     maven-plugins/junit-report/plugin.jelly
> 
>   Index: plugin.jelly
>   ===================================================================
>   RCS file: /home/cvs/maven-plugins/junit-report/plugin.jelly,v
>   retrieving revision 1.9
>   retrieving revision 1.10
>   diff -u -r1.9 -r1.10
>   --- plugin.jelly   28 Oct 2003 22:22:01 -0000   1.9
>   +++ plugin.jelly   29 Nov 2003 17:22:06 -0000   1.10
>   @@ -10,7 +10,7 @@
>        <j:if test="${unitTestSourcesPresent == 'true'}">
>          <doc:registerReport 
>            name="Unit Tests"
>   -        pluginName="maven-junit-report-plugin"
>   +        pluginName="junit-report"
>            description="Report on the results of the unit tests."
>            link="junit-report"/>
>        </j:if>
>   @@ -26,8 +26,15 @@
>      <!-- C R E A T E  J U N I T  X M L  R E P O R T     -->
>      <!-- 
================================================================== -->
> 
>   -  <goal
>   -    name="maven-junit-report-plugin:report"
>   +  <!-- 29/11/2003: Deprecated: needs to be removed sometime in the 
future -->
>   +  <goal name="maven-junit-report-plugin:report" 
>   +    prereqs="junit-report:report"
>   +    description="Generate a report from the test results (deprecated 
- 
> Please use junit-report:report instead)"
>   +
>   +  <goal name="junit-report:report"
>   +    description="Generate a report from the test results">
>   +
>   +  <goal name="junit-report:report"
>        description="Generate a report from the test results">
> 
>        <j:if test="${unitTestSourcesPresent == 'true'}">
> 
> 
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org