You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "cstamas (via GitHub)" <gi...@apache.org> on 2023/03/22 07:58:17 UTC
[GitHub] [maven-resolver] cstamas opened a new pull request, #271: [MRESOLVER-345] BD and DF collect differences with ranges
cstamas opened a new pull request, #271:
URL: https://github.com/apache/maven-resolver/pull/271
The two collector behave differently when in transitive dependencies ranges are in use.
---
https://issues.apache.org/jira/browse/MRESOLVER-345
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-resolver] cstamas commented on pull request #271: [MRESOLVER-345] BD and DF collect differences with ranges
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas commented on PR #271:
URL: https://github.com/apache/maven-resolver/pull/271#issuecomment-1479086460
Reason is simple: new BF does this:
https://github.com/apache/maven-resolver/blob/master/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/collect/bf/BfDependencyCollector.java#L409-L410
In short: new BF collects versions in reverse order (reverse of the found in metadata, DESC), while DF collects versions by the order in metadata (in both case we assume versions are in ascending order, example https://repo.maven.apache.org/maven2/org/apache/maven/maven-core/maven-metadata.xml)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-resolver] cstamas commented on pull request #271: [MRESOLVER-345] BD and DF collect differences with ranges
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas commented on PR #271:
URL: https://github.com/apache/maven-resolver/pull/271#issuecomment-1479186049
Created a "demo" snippet, and it produces this output:
```
org.apache.maven.resolver.demo.mresolver345:a:jar:1.0
+- org.apache.maven.resolver.demo.mresolver345:b:jar:1.0 [compile]
| \- org.apache.maven.resolver.demo.mresolver345:c:jar:3.0 [compile]
\- org.apache.maven.resolver.demo.mresolver345:c:jar:3.0 [compile]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-resolver] slawekjaranowski commented on a diff in pull request #271: [MRESOLVER-345] Conflict resolution in verbose mode is sensitive to version ordering
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on code in PR #271:
URL: https://github.com/apache/maven-resolver/pull/271#discussion_r1146862457
##########
maven-resolver-util/src/main/java/org/eclipse/aether/util/graph/visitor/DependencyGraphDumper.java:
##########
@@ -31,25 +31,27 @@
import org.eclipse.aether.util.graph.manager.DependencyManagerUtils;
import org.eclipse.aether.util.graph.transformer.ConflictResolver;
+import static java.util.Objects.requireNonNull;
+
/**
- * A dependency visitor that dumps the graph to the console.
+ * A dependency visitor that dumps the graph to any {@link Consumer<String>}. Meant for diagnostic and testing, as
+ * it may output the graph to standard output, error or even some logging interface.
+ *
+ * @since 1.9.8
*/
-public class ConsoleDependencyGraphDumper implements DependencyVisitor {
+public class DependencyGraphDumper implements DependencyVisitor {
Review Comment:
👍 - we have similar implementation in many places
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-resolver] cstamas merged pull request #271: [MRESOLVER-345] Conflict resolution in verbose mode is sensitive to version ordering
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas merged PR #271:
URL: https://github.com/apache/maven-resolver/pull/271
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org