You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by franz1981 <gi...@git.apache.org> on 2018/11/04 21:48:01 UTC
[GitHub] activemq-artemis pull request #2415: ARTEMIS-2100 address routing-type overr...
GitHub user franz1981 opened a pull request:
https://github.com/apache/activemq-artemis/pull/2415
ARTEMIS-2100 address routing-type overridden on attaching AMQP sender
AMQPSender has to honor an already existing multicast routingType
of an address while attempting to create a fresh new queue on it
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/franz1981/activemq-artemis ARTEMIS-2100_2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/2415.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2415
----
commit 8a1a23cff8d74175a9e821985611136cd97805bc
Author: Francesco Nigro <ni...@...>
Date: 2018-10-24T13:45:53Z
ARTEMIS-2100 address routing-type overridden on attaching AMQP sender
AMQPSender has to honor an already existing multicast routingType
of an address while attempting to create a fresh new queue on it
----
---
[GitHub] activemq-artemis issue #2415: ARTEMIS-2100 address routing-type overridden o...
Posted by andytaylor <gi...@git.apache.org>.
Github user andytaylor commented on the issue:
https://github.com/apache/activemq-artemis/pull/2415
This looks fine
---
[GitHub] activemq-artemis issue #2415: ARTEMIS-2100 address routing-type overridden o...
Posted by mtaylor <gi...@git.apache.org>.
Github user mtaylor commented on the issue:
https://github.com/apache/activemq-artemis/pull/2415
@franz1981 Thanks for making the requested changes. Merging
---
[GitHub] activemq-artemis issue #2415: ARTEMIS-2100 address routing-type overridden o...
Posted by franz1981 <gi...@git.apache.org>.
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/2415
According to the CI results:
On the left is master, while on the right is this PR branch +1
There are about 6 less failures and 1 more, but are almost intermittent ones, so it seems stable similarly to master.
---
[GitHub] activemq-artemis issue #2415: ARTEMIS-2100 address routing-type overridden o...
Posted by franz1981 <gi...@git.apache.org>.
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/2415
I'm running a full CI run on this one to check if it is safe :+1:
---
[GitHub] activemq-artemis pull request #2415: ARTEMIS-2100 address routing-type overr...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/2415
---