[GitHub] [doris] yangzhg commented on a diff in pull request #14377: [improvement](planner) eliminating useless sort node

[GitBox <gi...@apache.org>]

yangzhg commented on code in PR #14377:
URL: https://github.com/apache/doris/pull/14377#discussion_r1025943331


##########
fe/fe-core/src/main/java/org/apache/doris/planner/SingleNodePlanner.java:
##########
@@ -240,8 +242,12 @@ private PlanNode createQueryPlan(QueryStmt stmt, Analyzer analyzer, long default
             newDefaultOrderByLimit = 65535;
         }
         PlanNode root;
+        boolean canEliminatingSortNode = false;
         if (stmt instanceof SelectStmt) {
             SelectStmt selectStmt = (SelectStmt) stmt;
+            if (ConnectContext.get() != null && ConnectContext.get().getSessionVariable().enableEliminateSortNode) {

Review Comment:
   move this check to  `canEliminatingSortNode` func?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org