[GitHub] [hive] hsnusonic commented on a change in pull request #3006: HIVE-25575: Add support for JWT authentication in HTTP mode

[GitBox <gi...@apache.org>]

hsnusonic commented on a change in pull request #3006:
URL: https://github.com/apache/hive/pull/3006#discussion_r804907143



##########
File path: service/src/java/org/apache/hive/service/cli/thrift/ThriftHttpServlet.java
##########
@@ -737,6 +773,10 @@ private boolean isKerberosAuthMode(String authType) {
     return authType.equalsIgnoreCase(HiveAuthConstants.AuthTypes.KERBEROS.toString());
   }
 
+  private boolean isJWTAuthMode(String authType) {
+    return authType.toLowerCase().contains(HiveAuthConstants.AuthTypes.JWT.toString().toLowerCase());

Review comment:
       @kgyrtkirk After this commit https://github.com/apache/hive/commit/b975e47209fb188d047fa23aeaac058ae28fd393, we'd like to support multiple auth type in parallel. I'm thinking how to do this in a cleaner way.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org