You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Pradeep Agrawal <pr...@gmail.com> on 2018/11/02 06:05:00 UTC

Review Request 69238: RANGER-2275: Make db_setup retry delay configurable

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69238/
-----------------------------------------------------------

Review request for ranger, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Nikhil P, Ramesh Mani, and Velmurugan Periasamy.


Bugs: RANGER-2275
    https://issues.apache.org/jira/browse/RANGER-2275


Repository: ranger


Description
-------

**Problem Statement**: In an HA setup, Ranger Admin on both master nodes attempts to create/patch the DB and change passwords. If one of them detects contention for an operation, it sleeps and re-checks later. The length of sleep is fixed at 120 seconds

It would be better to make this delay configurable (in seconds) so that user can adjust the delay value as per his environment.

**Proposed Solution:**

The proposed patch introduces a parameter 'PATCH_RETRY_INTERVAL' in install.properties file which has default value 120 seconds.
This property is read during the run of db_setup.py and script shall set 'retryPatchAfterSeconds' variable with the given value of 'PATCH_RETRY_INTERVAL'.

If PATCH_RETRY_INTERVAL is not a number then default value will be 120.
If PATCH_RETRY_INTERVAL is removed then default value will be 120.


Diffs
-----

  security-admin/scripts/db_setup.py 3450fa690 
  security-admin/scripts/install.properties 30b946b31 


Diff: https://reviews.apache.org/r/69238/diff/1/


Testing
-------

Tested patch on local env by setting different values in the property PATCH_RETRY_INTERVAL.


Thanks,

Pradeep Agrawal


Re: Review Request 69238: RANGER-2275: Make db_setup retry delay configurable

Posted by Velmurugan Periasamy <vp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69238/#review210282
-----------------------------------------------------------


Ship it!




Ship It!

- Velmurugan Periasamy


On Nov. 2, 2018, 6:05 a.m., Pradeep Agrawal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69238/
> -----------------------------------------------------------
> 
> (Updated Nov. 2, 2018, 6:05 a.m.)
> 
> 
> Review request for ranger, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Nikhil P, Ramesh Mani, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2275
>     https://issues.apache.org/jira/browse/RANGER-2275
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> **Problem Statement**: In an HA setup, Ranger Admin on both master nodes attempts to create/patch the DB and change passwords. If one of them detects contention for an operation, it sleeps and re-checks later. The length of sleep is fixed at 120 seconds
> 
> It would be better to make this delay configurable (in seconds) so that user can adjust the delay value as per his environment.
> 
> **Proposed Solution:**
> 
> The proposed patch introduces a parameter 'PATCH_RETRY_INTERVAL' in install.properties file which has default value 120 seconds.
> This property is read during the run of db_setup.py and script shall set 'retryPatchAfterSeconds' variable with the given value of 'PATCH_RETRY_INTERVAL'.
> 
> If PATCH_RETRY_INTERVAL is not a number then default value will be 120.
> If PATCH_RETRY_INTERVAL is removed then default value will be 120.
> 
> 
> Diffs
> -----
> 
>   security-admin/scripts/db_setup.py 3450fa690 
>   security-admin/scripts/install.properties 30b946b31 
> 
> 
> Diff: https://reviews.apache.org/r/69238/diff/1/
> 
> 
> Testing
> -------
> 
> Tested patch on local env by setting different values in the property PATCH_RETRY_INTERVAL.
> 
> 
> Thanks,
> 
> Pradeep Agrawal
> 
>