[Bug 57569] FileServer.reserveFile - inconsistent behaviour when hasHeader is true

[bu...@apache.org]

https://issues.apache.org/bugzilla/show_bug.cgi?id=57569

Sebb <se...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Hardware|PC                          |All
                 OS|Mac OS X 10.4               |All

--- Comment #1 from Sebb <se...@apache.org> ---
FileServer.reserveFile has inconsistent behaviour when hasHeader is true.

The first time the method is called for a given file and alias, it will throw
IllegalArgumentException if the file cannot be opened.
However subsequent invocations will return null.

If the file exists but is empty, the method will always return null.

The method ought to be consistent in its behaviour. It should either always
return null, or always throw IllegalArgumentException.

The advantage of throwing IllegalArgumentException is that the exception can be
used to provide additional information on why the header is not available.

-- 
You are receiving this mail because:
You are the assignee for the bug.