You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/12/23 09:51:56 UTC
[GitHub] [shardingsphere] zhaojinchao95 opened a new pull request, #23061: Add ModeContextManager and split ClusterModeContextManager and StandaloneModeContextManager
zhaojinchao95 opened a new pull request, #23061:
URL: https://github.com/apache/shardingsphere/pull/23061
For #23042
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu merged pull request #23061: Add ModeContextManager interface and split ClusterModeContextManager and StandaloneModeContextManager
Posted by GitBox <gi...@apache.org>.
strongduanmu merged PR #23061:
URL: https://github.com/apache/shardingsphere/pull/23061
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #23061: Add ModeContextManager interface and split ClusterModeContextManager and StandaloneModeContextManager
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #23061:
URL: https://github.com/apache/shardingsphere/pull/23061#issuecomment-1363826986
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/23061?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#23061](https://codecov.io/gh/apache/shardingsphere/pull/23061?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (72ef44d) into [master](https://codecov.io/gh/apache/shardingsphere/commit/6e5f96442aeee6ced1c98a2cd3317fc61fd1450d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6e5f964) will **decrease** coverage by `0.07%`.
> The diff coverage is `30.17%`.
```diff
@@ Coverage Diff @@
## master #23061 +/- ##
============================================
- Coverage 50.05% 49.98% -0.08%
+ Complexity 2428 2425 -3
============================================
Files 4110 4112 +2
Lines 57341 57375 +34
Branches 9041 9045 +4
============================================
- Hits 28704 28678 -26
- Misses 26130 26193 +63
+ Partials 2507 2504 -3
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/23061?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...shardingsphere/infra/instance/InstanceContext.java](https://codecov.io/gh/apache/shardingsphere/pull/23061/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5mcmEvY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9pbnN0YW5jZS9JbnN0YW5jZUNvbnRleHQuamF2YQ==) | `35.29% <ø> (ø)` | |
| [...tsql/ral/UpdatableGlobalRuleRALBackendHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/23061/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9oYW5kbGVyL2Rpc3RzcWwvcmFsL1VwZGF0YWJsZUdsb2JhbFJ1bGVSQUxCYWNrZW5kSGFuZGxlci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [.../updatable/ImportDatabaseConfigurationHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/23061/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9oYW5kbGVyL2Rpc3RzcWwvcmFsL3VwZGF0YWJsZS9JbXBvcnREYXRhYmFzZUNvbmZpZ3VyYXRpb25IYW5kbGVyLmphdmE=) | `18.30% <0.00%> (ø)` | |
| [...nager/standalone/StandaloneModeContextManager.java](https://codecov.io/gh/apache/shardingsphere/pull/23061/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bW9kZS90eXBlL3N0YW5kYWxvbmUvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvbW9kZS9tYW5hZ2VyL3N0YW5kYWxvbmUvU3RhbmRhbG9uZU1vZGVDb250ZXh0TWFuYWdlci5qYXZh) | `7.01% <7.01%> (ø)` | |
| [...ode/manager/cluster/ClusterModeContextManager.java](https://codecov.io/gh/apache/shardingsphere/pull/23061/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bW9kZS90eXBlL2NsdXN0ZXIvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvbW9kZS9tYW5hZ2VyL2NsdXN0ZXIvQ2x1c3Rlck1vZGVDb250ZXh0TWFuYWdlci5qYXZh) | `15.00% <15.00%> (ø)` | |
| [...he/shardingsphere/mode/manager/ContextManager.java](https://codecov.io/gh/apache/shardingsphere/pull/23061/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bW9kZS9jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9tb2RlL21hbmFnZXIvQ29udGV4dE1hbmFnZXIuamF2YQ==) | `52.96% <62.50%> (+0.17%)` | :arrow_up: |
| [.../manager/cluster/ClusterContextManagerBuilder.java](https://codecov.io/gh/apache/shardingsphere/pull/23061/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bW9kZS90eXBlL2NsdXN0ZXIvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvbW9kZS9tYW5hZ2VyL2NsdXN0ZXIvQ2x1c3RlckNvbnRleHRNYW5hZ2VyQnVpbGRlci5qYXZh) | `84.37% <100.00%> (+1.61%)` | :arrow_up: |
| [...er/standalone/StandaloneContextManagerBuilder.java](https://codecov.io/gh/apache/shardingsphere/pull/23061/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bW9kZS90eXBlL3N0YW5kYWxvbmUvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvbW9kZS9tYW5hZ2VyL3N0YW5kYWxvbmUvU3RhbmRhbG9uZUNvbnRleHRNYW5hZ2VyQnVpbGRlci5qYXZh) | `84.21% <100.00%> (+4.21%)` | :arrow_up: |
| [...handler/database/CreateDatabaseBackendHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/23061/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9oYW5kbGVyL2RhdGFiYXNlL0NyZWF0ZURhdGFiYXNlQmFja2VuZEhhbmRsZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...d/handler/database/DropDatabaseBackendHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/23061/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9oYW5kbGVyL2RhdGFiYXNlL0Ryb3BEYXRhYmFzZUJhY2tlbmRIYW5kbGVyLmphdmE=) | `83.33% <100.00%> (ø)` | |
| ... and [41 more](https://codecov.io/gh/apache/shardingsphere/pull/23061/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org