You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2026/07/01 21:05:43 UTC
[PR] Bump MSRV to 1.88 [arrow-rs]
alamb opened a new pull request, #10254:
URL: https://github.com/apache/arrow-rs/pull/10254
# Which issue does this PR close?
Part of #10226.
# Rationale for this change
This implements the suggestion from https://github.com/apache/arrow-rs/issues/10226#issuecomment-4860000468 to bump the MSRV from Rust 1.85 to Rust 1.88 for the next major release.
# What changes are included in this PR?
- Updates the workspace MSRV to 1.88.
- Updates the standalone pyarrow testing crate MSRV pins to 1.88.
- Removes now-unnecessary `std::mem::transmute` workarounds in `arrow-array` that were only needed because const `f32::from_bits` and `f64::from_bits` were unavailable under the previous MSRV.
# Are there any user-facing changes?
Users building arrow-rs crates will need Rust 1.88 or newer.
# How was this tested?
- `cargo metadata --locked --no-deps`
- `cargo fmt --all -- --check`
- `cargo check -p arrow-array`
- `rustup run 1.88.0 cargo check -p arrow-array`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bump MSRV to 1.88 [arrow-rs]
Posted by "Jefffrey (via GitHub)" <gi...@apache.org>.
Jefffrey merged PR #10254:
URL: https://github.com/apache/arrow-rs/pull/10254
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bump MSRV to 1.88 [arrow-rs]
Posted by "Jefffrey (via GitHub)" <gi...@apache.org>.
Jefffrey commented on PR #10254:
URL: https://github.com/apache/arrow-rs/pull/10254#issuecomment-5173145549
thanks all
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bump MSRV to 1.88 [arrow-rs]
Posted by "emilk (via GitHub)" <gi...@apache.org>.
emilk commented on PR #10254:
URL: https://github.com/apache/arrow-rs/pull/10254#issuecomment-5170641580
Sideline suggestion: let's merge this first and update MSRV further in a separate PR (this one is already big!)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bump MSRV to 1.88 [arrow-rs]
Posted by "Jefffrey (via GitHub)" <gi...@apache.org>.
Jefffrey commented on PR #10254:
URL: https://github.com/apache/arrow-rs/pull/10254#issuecomment-5110923188
> any plans to move on with this bump?
we need to wait for the next major release, should be after 59.2.0 which is planned soon (this week?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bump MSRV to 1.88 [arrow-rs]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on PR #10254:
URL: https://github.com/apache/arrow-rs/pull/10254#issuecomment-5168630962
curious, would it be better if we bump MSRV to a later version? say 1.92 or 1.93? Those are still within the 6 months old policy.
For context: https://github.com/apache/arrow-rs/pull/10375#issuecomment-5159828419
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bump MSRV to 1.88 [arrow-rs]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #10254:
URL: https://github.com/apache/arrow-rs/pull/10254#issuecomment-5169314328
> curious, would it be better if we bump MSRV to a later version? say 1.92 or 1.93? Those are still within the 6 months old policy.
>
> For context: [#10375 (comment)](https://github.com/apache/arrow-rs/pull/10375#issuecomment-5159828419)
I would not have any problems with a later MSRV. What downstream crate requires that new a MSRV?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bump MSRV to 1.88 [arrow-rs]
Posted by "comphead (via GitHub)" <gi...@apache.org>.
comphead commented on PR #10254:
URL: https://github.com/apache/arrow-rs/pull/10254#issuecomment-5110887543
any plans to move on with this bump?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bump MSRV to 1.88 [arrow-rs]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #10254:
URL: https://github.com/apache/arrow-rs/pull/10254#discussion_r3509115854
##########
arrow-array/src/array/byte_array.rs:
##########
@@ -135,15 +135,15 @@ impl<T: ByteArrayType> GenericByteArray<T> {
// Verify that each pair of offsets is a valid slices of values
T::validate(&offsets, &values)?;
- if let Some(n) = nulls.as_ref() {
- if n.len() != len {
- return Err(ArrowError::InvalidArgumentError(format!(
- "Incorrect length of null buffer for {}{}Array, expected {len} got {}",
- T::Offset::PREFIX,
- T::PREFIX,
- n.len(),
- )));
- }
+ if let Some(n) = nulls.as_ref()
Review Comment:
Updating MSRV requires updating clippy as well
##########
Cargo.toml:
##########
@@ -82,7 +82,7 @@ include = [
"NOTICE.txt",
]
edition = "2024"
-rust-version = "1.85"
+rust-version = "1.88"
Review Comment:
This is the main change of this PR
##########
parquet/src/arrow/buffer/offset_buffer.rs:
##########
@@ -62,15 +62,13 @@ impl<I: OffsetSizeTrait> OffsetBuffer<I> {
/// UTF-8. This should be done by calling [`Self::check_valid_utf8`] after
/// all data has been written
pub fn try_push(&mut self, data: &[u8], validate_utf8: bool) -> Result<()> {
- if validate_utf8 {
- if let Some(&b) = data.first() {
- // A valid code-point iff it does not start with 0b10xxxxxx
- // Bit-magic taken from `std::str::is_char_boundary`
- if (b as i8) < -0x40 {
- return Err(ParquetError::General(
- "encountered non UTF-8 data".to_string(),
- ));
- }
+ if validate_utf8 && let Some(&b) = data.first() {
Review Comment:
this is all basically driven by the introduction of let chains
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bump MSRV to 1.88 [arrow-rs]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on PR #10254:
URL: https://github.com/apache/arrow-rs/pull/10254#issuecomment-5171043917
> I would not have any problems with a later MSRV. What downstream crate requires that new a MSRV?
not anything im aware of. https://github.com/apache/arrow-rs/pull/10375 needs `tonic 0.14.6` which requires MSRV 1.88
> let's merge this first and update MSRV further in a separate PR (this one is already big!)
yes! 100%
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org