You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Sergey Shelukhin <se...@hortonworks.com> on 2017/12/06 03:22:10 UTC
Review Request 64358: HIVE-18003 add explicit jdbc connection string
args for mappings
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64358/
-----------------------------------------------------------
Review request for hive and Prasanth_J.
Repository: hive-git
Description
-------
see jira
Diffs
-----
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 3be5a8dee4
jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java edf93859fe
jdbc/src/java/org/apache/hive/jdbc/Utils.java 855de881e9
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezTask.java af77f300c2
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/UserPoolMapping.java 33ee8f791f
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManager.java ecdcf12510
ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestWorkloadManager.java 78df962a3a
service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java fc9e6b2a91
Diff: https://reviews.apache.org/r/64358/diff/1/
Testing
-------
Thanks,
Sergey Shelukhin
Re: Review Request 64358: HIVE-18003 add explicit jdbc connection
string args for mappings
Posted by j....@gmail.com.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64358/#review193098
-----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezTask.java
Lines 167 (patched)
<https://reviews.apache.org/r/64358/#comment271596>
nit: use local variable userName?
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/UserPoolMapping.java
Lines 133 (patched)
<https://reviews.apache.org/r/64358/#comment271599>
nit: can be combined in if condition
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/UserPoolMapping.java
Lines 150 (patched)
<https://reviews.apache.org/r/64358/#comment271597>
nit: non-static
- Prasanth_J
On Dec. 6, 2017, 8:03 p.m., Sergey Shelukhin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64358/
> -----------------------------------------------------------
>
> (Updated Dec. 6, 2017, 8:03 p.m.)
>
>
> Review request for hive and Prasanth_J.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> see jira
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 75b77072c6
> jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java edf93859fe
> jdbc/src/java/org/apache/hive/jdbc/Utils.java 855de881e9
> ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezTask.java 8795cfcee1
> ql/src/java/org/apache/hadoop/hive/ql/exec/tez/UserPoolMapping.java 33ee8f791f
> ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManager.java dbdbbf25db
> ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestWorkloadManager.java c58e4507f2
>
>
> Diff: https://reviews.apache.org/r/64358/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sergey Shelukhin
>
>
Re: Review Request 64358: HIVE-18003 add explicit jdbc connection
string args for mappings
Posted by Sergey Shelukhin <se...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64358/
-----------------------------------------------------------
(Updated Dec. 6, 2017, 8:03 p.m.)
Review request for hive and Prasanth_J.
Repository: hive-git
Description
-------
see jira
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 75b77072c6
jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java edf93859fe
jdbc/src/java/org/apache/hive/jdbc/Utils.java 855de881e9
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezTask.java 8795cfcee1
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/UserPoolMapping.java 33ee8f791f
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManager.java dbdbbf25db
ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestWorkloadManager.java c58e4507f2
Diff: https://reviews.apache.org/r/64358/diff/3/
Changes: https://reviews.apache.org/r/64358/diff/2-3/
Testing
-------
Thanks,
Sergey Shelukhin
Re: Review Request 64358: HIVE-18003 add explicit jdbc connection
string args for mappings
Posted by Sergey Shelukhin <se...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64358/
-----------------------------------------------------------
(Updated Dec. 6, 2017, 3:24 a.m.)
Review request for hive and Prasanth_J.
Repository: hive-git
Description
-------
see jira
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 3be5a8dee4
jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java edf93859fe
jdbc/src/java/org/apache/hive/jdbc/Utils.java 855de881e9
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezTask.java af77f300c2
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/UserPoolMapping.java 33ee8f791f
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManager.java ecdcf12510
ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestWorkloadManager.java 78df962a3a
Diff: https://reviews.apache.org/r/64358/diff/2/
Changes: https://reviews.apache.org/r/64358/diff/1-2/
Testing
-------
Thanks,
Sergey Shelukhin