You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "jkbkupczyk (via GitHub)" <gi...@apache.org> on 2023/07/18 21:20:41 UTC
[GitHub] [commons-net] jkbkupczyk opened a new pull request, #165: Add IMAPReply tests and documentation fixes
jkbkupczyk opened a new pull request, #165:
URL: https://github.com/apache/commons-net/pull/165
- Updates ImapReply::isContinuation documentation to reflect method contract
- Fixes some Javadoc typos in AuthenticatingIMAPClient::AUTH_METHOD
- Migrates IMAPTest to JUnit5
- Adds IMAPReply tests (all data for tests comes from [RFC-3501)](https://datatracker.ietf.org/doc/html/rfc3501))
I also wonder, can we maybe add _junit-jupiter-params_ artifact to the project, so we can write [parameterized tests](https://junit.org/junit5/docs/current/user-guide/#writing-tests-parameterized-tests)?
FYI: @kinow @garydgregory
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-net] garydgregory merged pull request #165: Add IMAPReply tests and documentation fixes
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory merged PR #165:
URL: https://github.com/apache/commons-net/pull/165
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-net] jkbkupczyk commented on pull request #165: Add IMAPReply tests and documentation fixes
Posted by "jkbkupczyk (via GitHub)" <gi...@apache.org>.
jkbkupczyk commented on PR #165:
URL: https://github.com/apache/commons-net/pull/165#issuecomment-1642658090
> 😜 time to redo it then
ok 😁 will close that PR and open a new one, maybe I enhance this change add parameterized tests 😀
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-net] kinow commented on pull request #165: Add IMAPReply tests and documentation fixes
Posted by "kinow (via GitHub)" <gi...@apache.org>.
kinow commented on PR #165:
URL: https://github.com/apache/commons-net/pull/165#issuecomment-1642394341
Still seeing the same failure I saw yesterday on `master`. I have a Windows VM at $work, but haven't had much time to set up or test anything on that machine (using that to write docs/sharepoint/etc :disappointed: ). Maybe someone else can reproduce and try to fix the test on Win.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-net] garydgregory commented on pull request #165: Add IMAPReply tests and documentation fixes
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #165:
URL: https://github.com/apache/commons-net/pull/165#issuecomment-1642281499
Ah, no, got another random failure on master for Java 8 on Windows, which is what I am using locally...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-net] jkbkupczyk commented on pull request #165: Add IMAPReply tests and documentation fixes
Posted by "jkbkupczyk (via GitHub)" <gi...@apache.org>.
jkbkupczyk commented on PR #165:
URL: https://github.com/apache/commons-net/pull/165#issuecomment-1642593903
> This PR looks odd, you need to only have your commits in here. Git can be tricky sometimes...
ahh, I did it through Intellij, should have done it manually...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-net] garydgregory commented on pull request #165: Add IMAPReply tests and documentation fixes
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #165:
URL: https://github.com/apache/commons-net/pull/165#issuecomment-1642661560
You don't need to close this PR and open a new one, this creates noise on the mailing list and disconnects the history of the issue. It's better to keep it here IMO.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-net] garydgregory commented on pull request #165: Add IMAPReply tests and documentation fixes
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #165:
URL: https://github.com/apache/commons-net/pull/165#issuecomment-1642696517
I kicked off the builds...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-net] garydgregory commented on pull request #165: Add IMAPReply tests and documentation fixes
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #165:
URL: https://github.com/apache/commons-net/pull/165#issuecomment-1642238145
@jkbkupczyk
OK, I finally nailed the bulletproofing on the failing test.
Would you please rebase this PR on master? Then we should see a green build...
TY!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-net] garydgregory commented on pull request #165: Add IMAPReply tests and documentation fixes
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #165:
URL: https://github.com/apache/commons-net/pull/165#issuecomment-1642379826
@jkbkupczyk
OK, now you can rebase.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-net] garydgregory commented on pull request #165: Add IMAPReply tests and documentation fixes
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #165:
URL: https://github.com/apache/commons-net/pull/165#issuecomment-1641804438
Let's fix master before we do anything else. I'll look today.
It is ok to add the Junit test dependency for parameterized testing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-net] garydgregory commented on pull request #165: Add IMAPReply tests and documentation fixes
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #165:
URL: https://github.com/apache/commons-net/pull/165#issuecomment-1642585924
This PR looks odd, you need to only have your commits in here. Git can be tricky sometimes...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-net] garydgregory commented on pull request #165: Add IMAPReply tests and documentation fixes
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #165:
URL: https://github.com/apache/commons-net/pull/165#issuecomment-1642617320
😜
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-net] jkbkupczyk commented on pull request #165: Add IMAPReply tests and documentation fixes
Posted by "jkbkupczyk (via GitHub)" <gi...@apache.org>.
jkbkupczyk commented on PR #165:
URL: https://github.com/apache/commons-net/pull/165#issuecomment-1642693810
I think it's good RN. Would you mind looking at this @garydgregory, please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-net] jkbkupczyk commented on pull request #165: Add IMAPReply tests and documentation fixes
Posted by "jkbkupczyk (via GitHub)" <gi...@apache.org>.
jkbkupczyk commented on PR #165:
URL: https://github.com/apache/commons-net/pull/165#issuecomment-1642742312
Thank you @garydgregory and @kinow for review 😊
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org