You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "okumin (via GitHub)" <gi...@apache.org> on 2025/02/23 06:44:47 UTC

[PR] Core: Add "volatile" to HadoopFileIO#hadoopConf [iceberg]

okumin opened a new pull request, #12388:
URL: https://github.com/apache/iceberg/pull/12388

   This PR follows a warning message on a compilation.
   https://errorprone.info/bugpattern/DoubleCheckedLocking
   
   ```
   /.../iceberg/core/src/main/java/org/apache/iceberg/hadoop/HadoopFileIO.java:125: warning: [DoubleCheckedLocking] Double-checked locking on non-volatile fields is unsafe
       if (hadoopConf == null) {
       ^
       (see https://errorprone.info/bugpattern/DoubleCheckedLocking)
     Did you mean 'private volatile SerializableSupplier<Configuration> hadoopConf;'?
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Core: Add "volatile" to HadoopFileIO#hadoopConf [iceberg]

Posted by "okumin (via GitHub)" <gi...@apache.org>.
okumin commented on PR #12388:
URL: https://github.com/apache/iceberg/pull/12388#issuecomment-2681152050

   Thank you!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Core: Add "volatile" to HadoopFileIO#hadoopConf [iceberg]

Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra merged PR #12388:
URL: https://github.com/apache/iceberg/pull/12388


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org