[jira] [Commented] (FINERACT-1149) IllegalArgumentException at SQLBuilder.addCriteria() at StaffReadPlatformServiceImpl.retrieveAllLoanOfficersInOfficeById()

["Manthan Surkar (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FINERACT-1149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17194821#comment-17194821 ] 

Manthan Surkar commented on FINERACT-1149:
------------------------------------------

Thanks, Yes I will do the integration tests part.

> IllegalArgumentException at SQLBuilder.addCriteria() at StaffReadPlatformServiceImpl.retrieveAllLoanOfficersInOfficeById()
> --------------------------------------------------------------------------------------------------------------------------
>
>                 Key: FINERACT-1149
>                 URL: https://issues.apache.org/jira/browse/FINERACT-1149
>             Project: Apache Fineract
>          Issue Type: Bug
>    Affects Versions: 1.4.0
>            Reporter: Michael Vorburger
>            Assignee: Michael Vorburger
>            Priority: Blocker
>             Fix For: 1.5.0
>
>
> See FINERACT-932 for general background; I've found this in logs of [https://www.fineract.dev:|https://www.fineract.dev/]
> {code:java}
>  java.lang.IllegalArgumentException: criteria column name must match [a-zA-Z_][a-zA-Z0-9_-]*\.)?[a-zA-Z_-][a-zA-Z0-9_-]* : is_loan_officer= =
>         at org.apache.fineract.infrastructure.security.utils.SQLBuilder.addCriteria (SQLBuilder.java:79)
>         at org.apache.fineract.organisation.staff.service.StaffReadPlatformServiceImpl.retrieveAllLoanOfficersInOfficeById (StaffReadPlatformServiceImpl.java:164)
>         at org.apache.fineract.portfolio.loanaccount.service.LoanReadPlatformServiceImpl.retrieveAllowedLoanOfficers (LoanReadPlatformServiceImpl.java:1478)
>         at org.apache.fineract.portfolio.loanaccount.api.LoansApiResource.template (LoansApiResource.java:444){code}
> [~Manthan] FYI would you perhaps want to create an integration test for this? Just a thought.
> I'll raise a PR to fix it (as it seems to be a trivial problem).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)