[GitHub] [tinkerpop] Cole-Greer commented on a diff in pull request #2087: [WIP] Native transactions implementation

["Cole-Greer (via GitHub)" <gi...@apache.org>]

Cole-Greer commented on code in PR #2087:
URL: https://github.com/apache/tinkerpop/pull/2087#discussion_r1259029655


##########
gremlin-server/src/test/scripts/generate-all.groovy:
##########
@@ -36,7 +36,7 @@ globals << [hook : [
     // things now, that test config would have been mixed in with release artifacts and there would have been ugly
     // exclusions to make packaging work properly.
     allowSetOfIdManager = { graph, idManagerFieldName, idManager ->
-        java.lang.reflect.Field idManagerField = graph.class.getDeclaredField(idManagerFieldName)
+        java.lang.reflect.Field idManagerField = graph.class.getSuperclass().getDeclaredField(idManagerFieldName)

Review Comment:
   I'm not very familiar with this script, is `graph` in this context guaranteed to be an instance of either TinkerGraph or TinkerTransactionGraph? Is it possible that this may be used by other providers and inserting `getSuperclass()` will break their testing?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org