You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by ahgittin <gi...@git.apache.org> on 2016/11/24 17:30:42 UTC
[GitHub] brooklyn-server pull request #463: if AnyoneSecurityProvider is set explicit...
GitHub user ahgittin opened a pull request:
https://github.com/apache/brooklyn-server/pull/463
if AnyoneSecurityProvider is set explicitly then switch it out for Nop
improves logic of #434 -- https://github.com/apache/brooklyn-server/pull/434/commits/bfdf522c452df262b3b4bb55cd567ddf45b31fa7
that change caused some tests to fail if you had a security provider set in `brooklyn.properties` locally! this ensures that an explicit `AnyoneSecurityProvider` is respected.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ahgittin/brooklyn-server handle-anyone-provider-specially
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/brooklyn-server/pull/463.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #463
----
commit 18b49c355cc513b6ce937bc94f73db6bb8a4a54c
Author: Alex Heneveld <al...@cloudsoftcorp.com>
Date: 2016-11-24T17:27:06Z
if AnyoneSecurityProvider is set explicitly then switch it out for the Nop provider
we get a 401 otherwise (not sure why Anyone doesn't work in this context but the code previously works this way, so just improving the logic really)
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server pull request #463: if AnyoneSecurityProvider is set explicit...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/brooklyn-server/pull/463
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server issue #463: if AnyoneSecurityProvider is set explicitly then...
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on the issue:
https://github.com/apache/brooklyn-server/pull/463
LGTM, merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server issue #463: if AnyoneSecurityProvider is set explicitly then...
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the issue:
https://github.com/apache/brooklyn-server/pull/463
@neykov as you did #434 can you sanity check this? (should be very quick)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---