You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by Jean-Marc Spaggiari <je...@spaggiari.org> on 2013/10/21 15:50:15 UTC
Someone to look at HBASE-9543?
Hi,
One of our users proposed a patch under
HBASE-9543<https://issues.apache.org/jira/browse/HBASE-9543>
.
I exchanged a bit with him and patch seems to be good now.
Can a commiter have a look and provide comments? 2 other +1 are welcome.
Thanks,
JM
Re: Someone to look at HBASE-9543?
Posted by liushaohui <li...@xiaomi.com>.
There is not any special reason.
Just because we are used to use phabricator to review code.
I will re-post the review to reviews.apache.org if needed.
-liushaohui
On 10/21/2013 10:56 PM, Jean-Marc Spaggiari wrote:
> You're right. I did not figured that. Did not even clicked on the link ;)
>
> I don't think there was any particular reason.
>
> Thanks for looking at it.
>
> JM
>
>
> 2013/10/21 Ted Yu <yu...@gmail.com>
>
>> Will take a look when I get to office.
>>
>> One question: was there particular reason for review request to be posted
>> on reviews.facebook.net ?
>> If I am not mistaken, this is for Apache trunk, right ?
>>
>> Most people post on reviews.apache.org
>>
>> Cheers
>>
>>
>> On Mon, Oct 21, 2013 at 6:50 AM, Jean-Marc Spaggiari <
>> jean-marc@spaggiari.org> wrote:
>>
>>> Hi,
>>>
>>> One of our users proposed a patch under
>>> HBASE-9543<https://issues.apache.org/jira/browse/HBASE-9543>
>>> .
>>>
>>> I exchanged a bit with him and patch seems to be good now.
>>>
>>> Can a commiter have a look and provide comments? 2 other +1 are welcome.
>>>
>>> Thanks,
>>>
>>> JM
>>>
Re: Someone to look at HBASE-9543?
Posted by Ted Yu <yu...@gmail.com>.
I left some comment on the JIRA.
On Mon, Oct 21, 2013 at 7:56 AM, Jean-Marc Spaggiari <
jean-marc@spaggiari.org> wrote:
> You're right. I did not figured that. Did not even clicked on the link ;)
>
> I don't think there was any particular reason.
>
> Thanks for looking at it.
>
> JM
>
>
> 2013/10/21 Ted Yu <yu...@gmail.com>
>
> > Will take a look when I get to office.
> >
> > One question: was there particular reason for review request to be posted
> > on reviews.facebook.net ?
> > If I am not mistaken, this is for Apache trunk, right ?
> >
> > Most people post on reviews.apache.org
> >
> > Cheers
> >
> >
> > On Mon, Oct 21, 2013 at 6:50 AM, Jean-Marc Spaggiari <
> > jean-marc@spaggiari.org> wrote:
> >
> > > Hi,
> > >
> > > One of our users proposed a patch under
> > > HBASE-9543<https://issues.apache.org/jira/browse/HBASE-9543>
> > > .
> > >
> > > I exchanged a bit with him and patch seems to be good now.
> > >
> > > Can a commiter have a look and provide comments? 2 other +1 are
> welcome.
> > >
> > > Thanks,
> > >
> > > JM
> > >
> >
>
Re: Someone to look at HBASE-9543?
Posted by Jean-Marc Spaggiari <je...@spaggiari.org>.
You're right. I did not figured that. Did not even clicked on the link ;)
I don't think there was any particular reason.
Thanks for looking at it.
JM
2013/10/21 Ted Yu <yu...@gmail.com>
> Will take a look when I get to office.
>
> One question: was there particular reason for review request to be posted
> on reviews.facebook.net ?
> If I am not mistaken, this is for Apache trunk, right ?
>
> Most people post on reviews.apache.org
>
> Cheers
>
>
> On Mon, Oct 21, 2013 at 6:50 AM, Jean-Marc Spaggiari <
> jean-marc@spaggiari.org> wrote:
>
> > Hi,
> >
> > One of our users proposed a patch under
> > HBASE-9543<https://issues.apache.org/jira/browse/HBASE-9543>
> > .
> >
> > I exchanged a bit with him and patch seems to be good now.
> >
> > Can a commiter have a look and provide comments? 2 other +1 are welcome.
> >
> > Thanks,
> >
> > JM
> >
>
Re: Someone to look at HBASE-9543?
Posted by Ted Yu <yu...@gmail.com>.
Will take a look when I get to office.
One question: was there particular reason for review request to be posted
on reviews.facebook.net ?
If I am not mistaken, this is for Apache trunk, right ?
Most people post on reviews.apache.org
Cheers
On Mon, Oct 21, 2013 at 6:50 AM, Jean-Marc Spaggiari <
jean-marc@spaggiari.org> wrote:
> Hi,
>
> One of our users proposed a patch under
> HBASE-9543<https://issues.apache.org/jira/browse/HBASE-9543>
> .
>
> I exchanged a bit with him and patch seems to be good now.
>
> Can a commiter have a look and provide comments? 2 other +1 are welcome.
>
> Thanks,
>
> JM
>