[GitHub] storm pull request #1785: [STORM-2201] Add dynamic scheduler configuration l...

[jerrypeng <gi...@git.apache.org>]

Github user jerrypeng commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1785#discussion_r90526318
  
    --- Diff: storm-core/src/jvm/org/apache/storm/Config.java ---
    @@ -2177,13 +2177,37 @@
         @isMapEntryType(keyType = String.class, valueType = Number.class)
         public static final String MULTITENANT_SCHEDULER_USER_POOLS = "multitenant.scheduler.user.pools";
     
    +     /**
    +     * A plugin that should load the user pools for the multitenant scheduler
    +     */
    +    @isString
    +    public static final String MULTITENANT_SCHEDULER_USER_POOLS_LOADER = "multitenant.scheduler.user.pools.loader";
    +
    +    /**
    +     * Configuration elements for scheduler config loader
    +     */
    +    @isMapEntryType(keyType = String.class, valueType = String.class)
    +    public static final String MULTITENANT_SCHEDULER_USER_POOLS_LOADER_PARAMS = "multitenant.scheduler.user.pools.loader.params";
    +
         /**
          * A map of users to another map of the resource guarantees of the user. Used by Resource Aware Scheduler to ensure
          * per user resource guarantees.
          */
         @isMapEntryCustom(keyValidatorClasses = {StringValidator.class}, valueValidatorClasses = {UserResourcePoolEntryValidator.class})
         public static final String RESOURCE_AWARE_SCHEDULER_USER_POOLS = "resource.aware.scheduler.user.pools";
     
    +     /**
    +     * A plugin that should load the user pools for the resource aware scheduler
    +     */
    +    @isString
    +    public static final String RESOURCE_AWARE_SCHEDULER_USER_POOLS_LOADER = "resource.aware.scheduler.user.pools.loader";
    --- End diff --
    
    Yup that is what @isImplementationOfClass is for.  We should use it


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---