You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alex Clemmer <cl...@gmail.com> on 2016/03/11 19:40:12 UTC
Review Request 44722: Libprocess: Add `SOL_TCP` flag for Windows.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44722/
-----------------------------------------------------------
Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
Repository: mesos
Description
-------
Libprocess: Add `SOL_TCP` flag for Windows.
Diffs
-----
3rdparty/libprocess/src/config.hpp 1e0c2a5a61c3d1a7b50057f876f88a157a5e4ed8
Diff: https://reviews.apache.org/r/44722/diff/
Testing
-------
Thanks,
Alex Clemmer
Re: Review Request 44722: Libprocess: Add `SOL_TCP` flag for Windows.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44722/#review123213
-----------------------------------------------------------
Patch looks great!
Reviews applied: [44078, 44722]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On March 11, 2016, 6:40 p.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44722/
> -----------------------------------------------------------
>
> (Updated March 11, 2016, 6:40 p.m.)
>
>
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Libprocess: Add `SOL_TCP` flag for Windows.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/config.hpp 1e0c2a5a61c3d1a7b50057f876f88a157a5e4ed8
>
> Diff: https://reviews.apache.org/r/44722/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 44722: Libprocess: Add `SOL_TCP` flag for Windows.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44722/#review123797
-----------------------------------------------------------
Ship it!
Ship It!
- Joris Van Remoortere
On March 11, 2016, 6:40 p.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44722/
> -----------------------------------------------------------
>
> (Updated March 11, 2016, 6:40 p.m.)
>
>
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Libprocess: Add `SOL_TCP` flag for Windows.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/config.hpp 1e0c2a5a61c3d1a7b50057f876f88a157a5e4ed8
>
> Diff: https://reviews.apache.org/r/44722/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Clemmer
>
>