You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2021/08/21 19:03:41 UTC
[GitHub] [commons-compress] HelderMagalhaes opened a new pull request #217: Documentation nits
HelderMagalhaes opened a new pull request #217:
URL: https://github.com/apache/commons-compress/pull/217
Redid #199 (and implicitly #198 and #197) from scratch:
* Now "rebased" on master as hinted by @garydgregory (on #199)
* More squashed than previous as advised by @PeterAlfredLee (on #199)
* A separate commit for whitespace as suggested by @bodewig ([follow-up](https://github.com/apache/commons-compress/pull/192#issuecomment-846393334) from #192)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-compress] garydgregory commented on a change in pull request #217: Documentation nits
Posted by GitBox <gi...@apache.org>.
garydgregory commented on a change in pull request #217:
URL: https://github.com/apache/commons-compress/pull/217#discussion_r693498998
##########
File path: src/site/site.xml
##########
@@ -56,7 +57,6 @@
<item name="1.8" href="javadocs/api-1.8/index.html"/>
Review comment:
Instead of keep this list, why not point to javadoc.io like we do here https://commons.apache.org/proper/commons-io/ ?
##########
File path: src/site/site.xml
##########
@@ -56,7 +57,6 @@
<item name="1.8" href="javadocs/api-1.8/index.html"/>
Review comment:
Instead of keeping this list, why not point to javadoc.io like we do here https://commons.apache.org/proper/commons-io/ ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-compress] PeterAlfredLee commented on a change in pull request #217: Documentation nits
Posted by GitBox <gi...@apache.org>.
PeterAlfredLee commented on a change in pull request #217:
URL: https://github.com/apache/commons-compress/pull/217#discussion_r700168882
##########
File path: src/site/xdoc/tar.xml
##########
@@ -129,14 +129,14 @@
<p>Prior to Commons Compress 1.20 <code>TarArchiveInputStream</code> would recognize sparse
file entries stored using the "oldgnu" format
(<code>--sparse-version=0.0</code> in GNU tar) but not
- able to extract them correctly. Starting with Commons Compress
+ able to extract them correctly. Starting with Commons Compress 1.21
Review comment:
I think this should be 1.20.
#87 introduced this feature and it's included in 1.20
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-compress] coveralls edited a comment on pull request #217: Documentation nits
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #217:
URL: https://github.com/apache/commons-compress/pull/217#issuecomment-903162775
[](https://coveralls.io/builds/42588724)
Coverage remained the same at 86.36% when pulling **1e1874a96ce1a558520ee5e944534b4cf33ad63e on HelderMagalhaes:documentation-nits** into **da22ecf0fd91cdd5abd105692ff81ba40a5c27cf on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-compress] garydgregory merged pull request #217: Documentation nits
Posted by GitBox <gi...@apache.org>.
garydgregory merged pull request #217:
URL: https://github.com/apache/commons-compress/pull/217
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-compress] HelderMagalhaes commented on a change in pull request #217: Documentation nits
Posted by GitBox <gi...@apache.org>.
HelderMagalhaes commented on a change in pull request #217:
URL: https://github.com/apache/commons-compress/pull/217#discussion_r693530228
##########
File path: src/site/site.xml
##########
@@ -56,7 +57,6 @@
<item name="1.8" href="javadocs/api-1.8/index.html"/>
Review comment:
> Instead of keeping this list, why not point to javadoc.io like we do here https://commons.apache.org/proper/commons-io/ ?
Sounds like a good idea, but possibly a bit off-topic for specific changes as these ones: according to I've seen in _commons-io_, it seems that the (commons-compress) download page would also need some work in order to list previous versions, together with the javadoc links. Could I suggest creating a follow-up on this? 😉
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-compress] HelderMagalhaes commented on a change in pull request #217: Documentation nits
Posted by GitBox <gi...@apache.org>.
HelderMagalhaes commented on a change in pull request #217:
URL: https://github.com/apache/commons-compress/pull/217#discussion_r720735159
##########
File path: src/site/site.xml
##########
@@ -56,7 +57,6 @@
<item name="1.8" href="javadocs/api-1.8/index.html"/>
Review comment:
> Could I suggest creating a follow-up on this? 😉
I've created the follow-up: [COMPRESS-593](https://issues.apache.org/jira/projects/COMPRESS/issues/COMPRESS-593)
Please add any relevant suggestions there. 🙂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-compress] HelderMagalhaes commented on pull request #217: Documentation nits
Posted by GitBox <gi...@apache.org>.
HelderMagalhaes commented on pull request #217:
URL: https://github.com/apache/commons-compress/pull/217#issuecomment-903255869
Added a last-minute found batch of spelling fixes. Not squashed with previous "spelling and grammar check" but, given the measurable number of entries, I felt like it was better being shipped in this PR than creating a separate one. 🙂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-compress] coveralls edited a comment on pull request #217: Documentation nits
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #217:
URL: https://github.com/apache/commons-compress/pull/217#issuecomment-903162775
[](https://coveralls.io/builds/42319846)
Coverage remained the same at 86.36% when pulling **95aca18426ac0364cbc37c9f19a7d3ef97fab8fb on HelderMagalhaes:documentation-nits** into **da22ecf0fd91cdd5abd105692ff81ba40a5c27cf on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-compress] PeterAlfredLee commented on pull request #217: Documentation nits
Posted by GitBox <gi...@apache.org>.
PeterAlfredLee commented on pull request #217:
URL: https://github.com/apache/commons-compress/pull/217#issuecomment-913962345
Looks good to me now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-compress] coveralls commented on pull request #217: Documentation nits
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #217:
URL: https://github.com/apache/commons-compress/pull/217#issuecomment-903162775
[](https://coveralls.io/builds/42316703)
Coverage remained the same at 86.36% when pulling **ed8df128857f603b00843e8899e5af6bc04a7a59 on HelderMagalhaes:documentation-nits** into **da22ecf0fd91cdd5abd105692ff81ba40a5c27cf on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org