You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by GitBox <gi...@apache.org> on 2022/09/23 11:54:22 UTC
[GitHub] [myfaces] melloware opened a new pull request, #318: MYFACES-4456: Add type to HtmlInputText
melloware opened a new pull request, #318:
URL: https://github.com/apache/myfaces/pull/318
Adds type to HtmlInputText and adds unit tests proving the default is still `type="text"` but can now be set properly on the tag like `type="tel"` etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] tandraschko commented on pull request #318: MYFACES-4456: Add type to HtmlInputText
Posted by GitBox <gi...@apache.org>.
tandraschko commented on PR #318:
URL: https://github.com/apache/myfaces/pull/318#issuecomment-1256187195
-0 for adding such a warning
there would be much more useful warnings like https://issues.apache.org/jira/projects/MYFACES/issues/MYFACES-3127?filter=allopenissues
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] melloware commented on pull request #318: MYFACES-4456: Add type to HtmlInputText
Posted by GitBox <gi...@apache.org>.
melloware commented on PR #318:
URL: https://github.com/apache/myfaces/pull/318#issuecomment-1256183337
I saw that but felt like it was overkill to warn the user? I see Mojarra is doing that but not sure that is really necessary?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] melloware commented on pull request #318: MYFACES-4456: Add type to HtmlInputText
Posted by GitBox <gi...@apache.org>.
melloware commented on PR #318:
URL: https://github.com/apache/myfaces/pull/318#issuecomment-1256183602
I can add that though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] pnicolucci commented on pull request #318: MYFACES-4456: Add type to HtmlInputText
Posted by GitBox <gi...@apache.org>.
pnicolucci commented on PR #318:
URL: https://github.com/apache/myfaces/pull/318#issuecomment-1256211871
I don't feel strongly either way, just wanted to note what the doc stated. If the community consensus is to not add it I'm fine with that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] melloware merged pull request #318: MYFACES-4456: Add type to HtmlInputText
Posted by GitBox <gi...@apache.org>.
melloware merged PR #318:
URL: https://github.com/apache/myfaces/pull/318
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] melloware commented on pull request #318: MYFACES-4456: Add type to HtmlInputText
Posted by GitBox <gi...@apache.org>.
melloware commented on PR #318:
URL: https://github.com/apache/myfaces/pull/318#issuecomment-1256214749
OK warning added exactly like Mojarra does it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] pnicolucci commented on pull request #318: MYFACES-4456: Add type to HtmlInputText
Posted by GitBox <gi...@apache.org>.
pnicolucci commented on PR #318:
URL: https://github.com/apache/myfaces/pull/318#issuecomment-1256177471
Looking at the vld doc: https://jakarta.ee/specifications/faces/4.0/vdldoc/ I see
it states the following:
> Controls the data type and associated control of the element. Default value is text.
> If a value is specified for which already a more specific component exist, such as
> hidden, password, checkbox, radio, file, submit, image, reset and button, and the
> ProjectStage is set to Development, then the renderer must add a warning message
> stating that the more specific component should be preferred.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org