You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/09/29 10:03:45 UTC

[GitHub] [cloudstack-primate] shwstppr opened a new pull request #763: network: fix create offering values

shwstppr opened a new pull request #763:
URL: https://github.com/apache/cloudstack-primate/pull/763


   Fixes #757 
   
   createNetworkOffering API should have values for keys - `promiscuousmode`, `macaddresschanges`, `forgedtransmits` of `details` param as `true` or `false`


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] rhtyd merged pull request #763: network: fix create offering values

Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #763:
URL: https://github.com/apache/cloudstack-primate/pull/763


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] shwstppr commented on pull request #763: network: fix create offering values

Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #763:
URL: https://github.com/apache/cloudstack-primate/pull/763#issuecomment-700602695


   @blueorangutan package
   
   @rhtyd @davidjumani please check cc @alexandremattioli


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #763: network: fix create offering values

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #763:
URL: https://github.com/apache/cloudstack-primate/pull/763#issuecomment-700603110


   @shwstppr a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #763: network: fix create offering values

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #763:
URL: https://github.com/apache/cloudstack-primate/pull/763#issuecomment-700607810


   Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
   QA: http://primate-qa.cloudstack.cloud:8080/client/pr/763 (JID-3537)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] davidjumani commented on a change in pull request #763: network: fix create offering values

Posted by GitBox <gi...@apache.org>.
davidjumani commented on a change in pull request #763:
URL: https://github.com/apache/cloudstack-primate/pull/763#discussion_r496606813



##########
File path: src/views/offering/AddNetworkOffering.vue
##########
@@ -894,13 +894,13 @@ export default {
         if ('egressdefaultpolicy' in values && values.egressdefaultpolicy !== 'allow') {
           params.egressdefaultpolicy = false
         }
-        if ('promiscuousmode' in values) {
+        if ('promiscuousmode' in values && values.promiscuousmode !== '') {

Review comment:
       @shwstppr Would this be simpler ?
   ```
   if (values.promiscuousmode)
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org